Multicast port is now configurable. #229
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use Cling in order to detect the local UPNP router of the lan, and to ask it to open a port with the current computer. I have made some tests, and they work under Linux and under Windows. However, I can't do these tests under MacOS. Here the log of Cling :
It appears that the port 1900 is officially used by "Back to my mac" on mac OS. But if I make a netstat ou a lsof, no port is opened.
I have read the code, but there is no possibility to change the multicast port. So I have changed the code to enable it. It does not produce regression and it enables me to open another port than 1900. Then, with these modifications, I can open a port with my UPNP router.
So I propose you to accept this pull request.
Best regards,
Jason.