Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add french language + Fixing #9

Merged
merged 8 commits into from
May 13, 2023

Conversation

amirroox
Copy link
Contributor

@amirroox amirroox commented May 12, 2023

با سلام و عرض خسته نباشید . زبان فرانسوی به عنوان Branch جدید به پروژه اضافه شد . (پوشه steps ایجاد شده و تمامی فایل ها ترجمه شده اند) علاوه بر تغییرات زبانی چنیدن مشکل اعم از لینک دهی ها بهبود یافتند و همچنین عکس پین Galaxy Brain اضافه شد .

@amirroox
Copy link
Contributor Author

بهبود لینک دهی :
آدرس های :
https://github.com/4xmen/Get-Github-Achievements/blob/main/.......
به آدرس های بدون این قسمت تبدیل شده اند (برای دسترسی مستقیم از هر فورک )

Copy link
Member

@YasinDehfuli YasinDehfuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You change the links to other languages pages by changing it.
i show you a sample to change main translated languages

https://github.com/4xmen/Get-Github-Achievements/blob/master/YOUR-NEW-README.md-HERE

add your main new language translate must be in YOUR-NEW-README.md-HERE;

Add README.fr.md in there

README.de.md Outdated
@@ -3,13 +3,13 @@
## Sprache
<div align="center">

[![en](https://img.shields.io/badge/Lang-English-blue.svg)](https://github.com/4xmen/Get-Github-Achievements/blob/master/README.md)
[![en](https://img.shields.io/badge/Lang-English-blue.svg)](README.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't change the link, now the link is broken

README.de.md Outdated
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
[![fa](https://img.shields.io/badge/Lang-Persian-green.svg)](https://github.com/4xmen/Get-Github-Achievements/blob/master/README.fa.md)
[![fa](https://img.shields.io/badge/Lang-Persian-green.svg)](README.fa.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.de.md Outdated
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
[![de](https://img.shields.io/badge/Lang-Deutsch-yellow.svg)](https://github.com/4xmen/Get-Github-Achievements/blob/master/README.de.md)
[![de](https://img.shields.io/badge/Lang-Deutsch-yellow.svg)](README.de.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you broke the link here

README.de.md Outdated
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
[![fr](https://img.shields.io/badge/Lang-french-orange.svg)](https://github.com/4xmen/Get-Github-Achievements/blob/master/README.fr.md)
[![fr](https://img.shields.io/badge/Lang-french-orange.svg)](README.fr.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you broke the link here

README.fa.md Outdated
@@ -6,13 +6,13 @@

<div align="center">

[![en](https://img.shields.io/badge/Lang-English-blue.svg)](https://github.com/4xmen/Get-Github-Achievements/blob/master/README.md)
[![en](https://img.shields.io/badge/Lang-English-blue.svg)](README.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't change true parts that work successfully, now you broke the link

README.fa.md Outdated
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
[![fa](https://img.shields.io/badge/Lang-Persian-green.svg)](https://github.com/4xmen/Get-Github-Achievements/blob/master/README.fa.md)
[![fa](https://img.shields.io/badge/Lang-Persian-green.svg)](README.fa.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the link didn't work like this

README.fr.md Outdated
@@ -4,13 +4,13 @@

<div align="center">

[![en](https://img.shields.io/badge/Lang-English-blue.svg)](https://github.com/4xmen/Get-Github-Achievements/blob/master/README.md)
[![en](https://img.shields.io/badge/Lang-English-blue.svg)](README.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please code like other samples, don't change it, links didn't work like this

README.fr.md Outdated
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
[![fr](https://img.shields.io/badge/Lang-french-orange.svg)](https://github.com/4xmen/Get-Github-Achievements/blob/master/README.fr.md)
[![fr](https://img.shields.io/badge/Lang-french-orange.svg)](README.fr.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change the changes, like other pages sample, your changes on links broken the link to other languages pages , fix it and pull again

@YasinDehfuli
Copy link
Member

با سلام تغییر در لینک باعث میشود دسترسی به بخش ها مسدود شود بر طبق نحوه کار README لطفا لینک هارا به حالت اولیه تغییر دهید و از همان روش برای لینک کردن استفاده کنید که استفاده شده بود. با تشکر از زحمات شما

@YasinDehfuli YasinDehfuli added the documentation Improvements or additions to documentation label May 13, 2023
@amirroox
Copy link
Contributor Author

سلامی دوباره ، لینک ها به حالت عادی برگشتند (البته من تست کردم ، مشکلی از نظر لینک دهی نداشت و به همین صورت هم به صفحات جدید منتقل میشد) در هر صورت لینک های گفته شده به حالت عادی برگشتند

@@ -4,13 +4,13 @@

<div align="center">

[![en](https://img.shields.io/badge/Lang-English-blue.svg)](README.md)
[![en](https://img.shields.io/badge/Lang-English-blue.svg)](https://github.com/4xmen/Get-Github-Achievements/blob/master/README.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

تشکر از فیکس بخش ها - لینک قبلی در صورتی که در گیت هاب پوش میشد فعال نمیبود. قبلا امتحان شده بود این روش - تشکر از تغییرات شما

Copy link
Member

@YasinDehfuli YasinDehfuli May 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

با تشکر از شما دوست عزیز @amirroox

تمامی بخش ها منظم و مرتب بوده و ساختار اصلی حفظ شده. همکاری با شما باعث خوشحالی ماست.

با تشکر @YasinDehfuli

@YasinDehfuli YasinDehfuli merged commit e3f6cda into 4xmen:main May 13, 2023
@4xmen 4xmen deleted a comment from amirroox May 13, 2023
@YasinDehfuli
Copy link
Member

دوست عزیز @amirroox
خوشحالیم از اینکه شاهد این هستیم که پین Pull Shark را دریافت کردید و این اتفاق در کنار تیم 4xmen بوده.
از تمامی زحمات شما سپاسگذاریم.

از طرف تیم 4xmen

@amirroox
Copy link
Contributor Author

منم خوشحال شدم تا تونستم قسمتی از این پروژه رو تکمیل کنم
و برای اینکه کاربران ترغیب بشن برای دریافت پین ها و همچنین کمک به بقیه پروژه ها با این اکانت درخواست دادم
موفق و پیروز باشید

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants