-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add french language + Fixing #9
Conversation
…DME.de.md README.fa.md README.fr.md]
بهبود لینک دهی : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You change the links to other languages pages by changing it.
i show you a sample to change main translated languages
https://github.com/4xmen/Get-Github-Achievements/blob/master/YOUR-NEW-README.md-HERE
add your main new language translate must be in YOUR-NEW-README.md-HERE;
Add README.fr.md in there
README.de.md
Outdated
@@ -3,13 +3,13 @@ | |||
## Sprache | |||
<div align="center"> | |||
|
|||
[![en](https://img.shields.io/badge/Lang-English-blue.svg)](https://github.com/4xmen/Get-Github-Achievements/blob/master/README.md) | |||
[![en](https://img.shields.io/badge/Lang-English-blue.svg)](README.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't change the link, now the link is broken
README.de.md
Outdated
| ||
[![fa](https://img.shields.io/badge/Lang-Persian-green.svg)](https://github.com/4xmen/Get-Github-Achievements/blob/master/README.fa.md) | ||
[![fa](https://img.shields.io/badge/Lang-Persian-green.svg)](README.fa.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you broke the link https://github.com/4xmen/Get-Github-Achievements/blob/master/README.fa.md is true link
README.de.md
Outdated
| ||
[![de](https://img.shields.io/badge/Lang-Deutsch-yellow.svg)](https://github.com/4xmen/Get-Github-Achievements/blob/master/README.de.md) | ||
[![de](https://img.shields.io/badge/Lang-Deutsch-yellow.svg)](README.de.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you broke the link here
README.de.md
Outdated
| ||
[![fr](https://img.shields.io/badge/Lang-french-orange.svg)](https://github.com/4xmen/Get-Github-Achievements/blob/master/README.fr.md) | ||
[![fr](https://img.shields.io/badge/Lang-french-orange.svg)](README.fr.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you broke the link here
README.fa.md
Outdated
@@ -6,13 +6,13 @@ | |||
|
|||
<div align="center"> | |||
|
|||
[![en](https://img.shields.io/badge/Lang-English-blue.svg)](https://github.com/4xmen/Get-Github-Achievements/blob/master/README.md) | |||
[![en](https://img.shields.io/badge/Lang-English-blue.svg)](README.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't change true parts that work successfully, now you broke the link
README.fa.md
Outdated
| ||
[![fa](https://img.shields.io/badge/Lang-Persian-green.svg)](https://github.com/4xmen/Get-Github-Achievements/blob/master/README.fa.md) | ||
[![fa](https://img.shields.io/badge/Lang-Persian-green.svg)](README.fa.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the link didn't work like this
README.fr.md
Outdated
@@ -4,13 +4,13 @@ | |||
|
|||
<div align="center"> | |||
|
|||
[![en](https://img.shields.io/badge/Lang-English-blue.svg)](https://github.com/4xmen/Get-Github-Achievements/blob/master/README.md) | |||
[![en](https://img.shields.io/badge/Lang-English-blue.svg)](README.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please code like other samples, don't change it, links didn't work like this
README.fr.md
Outdated
| ||
[![fr](https://img.shields.io/badge/Lang-french-orange.svg)](https://github.com/4xmen/Get-Github-Achievements/blob/master/README.fr.md) | ||
[![fr](https://img.shields.io/badge/Lang-french-orange.svg)](README.fr.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change the changes, like other pages sample, your changes on links broken the link to other languages pages , fix it and pull again
با سلام تغییر در لینک باعث میشود دسترسی به بخش ها مسدود شود بر طبق نحوه کار README لطفا لینک هارا به حالت اولیه تغییر دهید و از همان روش برای لینک کردن استفاده کنید که استفاده شده بود. با تشکر از زحمات شما |
سلامی دوباره ، لینک ها به حالت عادی برگشتند (البته من تست کردم ، مشکلی از نظر لینک دهی نداشت و به همین صورت هم به صفحات جدید منتقل میشد) در هر صورت لینک های گفته شده به حالت عادی برگشتند |
@@ -4,13 +4,13 @@ | |||
|
|||
<div align="center"> | |||
|
|||
[![en](https://img.shields.io/badge/Lang-English-blue.svg)](README.md) | |||
[![en](https://img.shields.io/badge/Lang-English-blue.svg)](https://github.com/4xmen/Get-Github-Achievements/blob/master/README.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
تشکر از فیکس بخش ها - لینک قبلی در صورتی که در گیت هاب پوش میشد فعال نمیبود. قبلا امتحان شده بود این روش - تشکر از تغییرات شما
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
با تشکر از شما دوست عزیز @amirroox
تمامی بخش ها منظم و مرتب بوده و ساختار اصلی حفظ شده. همکاری با شما باعث خوشحالی ماست.
با تشکر @YasinDehfuli
منم خوشحال شدم تا تونستم قسمتی از این پروژه رو تکمیل کنم |
با سلام و عرض خسته نباشید . زبان فرانسوی به عنوان Branch جدید به پروژه اضافه شد . (پوشه steps ایجاد شده و تمامی فایل ها ترجمه شده اند) علاوه بر تغییرات زبانی چنیدن مشکل اعم از لینک دهی ها بهبود یافتند و همچنین عکس پین Galaxy Brain اضافه شد .