merge(albums_api): add api endpoints for albums & tests. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
5-pebbles
commented
Mar 4, 2024
5-pebbles
commented
- feat(albums_api): add api endpoints for albums.
- feat(tests): add tests for albums api endpoints.
5-pebbles
commented
Mar 5, 2024
Comment on lines
+34
to
+39
| for track in album.tracks.iter() { | ||
| tx.execute( | ||
| "INSERT INTO album_tracks (album_id, track_id) VALUES (?1, ?2)", | ||
| params![album.id, track], | ||
| )?; | ||
| } |
There was a problem hiding this comment.
This needs to be tested.
It can't be done yet because no track endpoints have been implemented, but it does need to happen when they are.
Comment on lines
+172
to
+174
| tx.execute("DELETE FROM album_genres WHERE album_id = ?", params![id])?; | ||
| tx.execute("DELETE FROM artist_albums WHERE album_id = ?", params![id])?; | ||
| tx.execute("DELETE FROM album_tracks WHERE album_id = ?", params![id])?; |
There was a problem hiding this comment.
These also need to be tested. They are fairly straight forward, so I think that can be left until after the track apis are implemented. Though there is currently no plan for an endpoint that could test the genre album junctions... the joy of using exclusively e2e testing...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.