Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notch Simulator automatically resizes Game window and configurable device orientation in Notch Simulator Window #54

Merged
merged 3 commits into from
Dec 27, 2021

Conversation

yasirkula
Copy link
Contributor

@yasirkula yasirkula commented Dec 7, 2020

Addressed issues:

Note that in the following 2 cases, Game window won't/can't be resized via Notch Simulator:

  • when Unity Device Simulator is open
  • when Game window isn't open on Unity 2019.2 or earlier (i.e. when Scene window is maximized)

The updated Notch Simulator window:

NotchSimulatorWindow

…y effect in 2 cases: 1) when Unity Device Simulator is open, 2) when Game window isn't open on Unity 2019.2 or earlier (i.e. when Scene window is maximized)

- Previewed device's orientation can be specified from Notch Simulator window
…SolutionUIBehaviourBase so that it can be extended by custom user scripts (addresses #53)
…view can't be resized automatically (i.e when Unity Device Simulator is open, or Game window isn't open on Unity 2019.2 or earlier)
@5argon 5argon merged commit f536e92 into 5argon:master Dec 27, 2021
@5argon
Copy link
Owner

5argon commented Dec 27, 2021

Thank you for your PR! I had no time for years to maintain this, now I am getting back to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants