Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gradle GitHub action #194

Merged
merged 21 commits into from
Feb 23, 2025
Merged

Add gradle GitHub action #194

merged 21 commits into from
Feb 23, 2025

Conversation

brericha
Copy link
Collaborator

Runs gradle build and gradle test on any merge or push into master.

Not ready to merge yet, gotta see if there's a way to test that the action works first.

@brericha
Copy link
Collaborator Author

When I finally figure this out I'll do another branch so we don't clutter the commit lot with all these attempts

@brericha
Copy link
Collaborator Author

brericha commented Feb 21, 2025

It appears to be working now but the build currently fails because lint is catching a problem, see issue #195

@dektar
Copy link
Collaborator

dektar commented Feb 22, 2025

This is stellar. LG after we fix the build error. I can pick that up as I just did another back pressed handling, or you are welcome to it (please assign yourself if you do it so we don't step on each other).

I'd just suggest we talk with Nick to make sure there's no limit or at least no small limit to how many github actions we can perform. I'm not sure if/how we pay for GitHub.

@nickoneill
Copy link
Member

We have a non-profit business account on GitHub so I would not worry about action limits (I think the free tier is already fine for just a handful of people making PRs anyway). As for commits, you can still use this branch @brericha, just pick "Squash and merge" rather than "Merge" when done.

Copy link
Collaborator

@dektar dektar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for working on this! It'll be great to have.

@dektar dektar marked this pull request as ready for review February 23, 2025 13:39
@dektar dektar merged commit 62c7d72 into master Feb 23, 2025
1 check passed
@brericha brericha deleted the gradle-action branch February 23, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants