Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add button to enable reminders in the tutorial #218

Merged
merged 2 commits into from
Mar 3, 2025
Merged

Add button to enable reminders in the tutorial #218

merged 2 commits into from
Mar 3, 2025

Conversation

dektar
Copy link
Collaborator

@dektar dektar commented Mar 2, 2025 •
edited
Loading

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization

Description

  • Hides new button once notifications are denied or accepted, or once reminders are enabled
  • Shows help text once button is interacted with, for either possible outcome
    Also:
  • Hides call count rather than showing a toast error when not connected to network in tutorial
  • Removes outdated upgrade path in main for reminding the user about notifications
  • Tracks from-notification main page views differently from main page views

Related Issues

Were the changes tested?

  • Yes, automated tests in please name test methods or files
  • Yes, manually tested:Texted extensively in nexus 5x and pixel 6a, including rotation, disabling/enabling notification permission, ensuring notifications fire after enabling in tutorial w/o visiting settings page
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

dektar added 2 commits March 2, 2025 14:51
@dektar
Add button to turn on notifications in tutorial
f3812be 
* Hides button once notifications are denied or accepted
* Shows help text once button is interacted with, for each possible outcome
* Removes outdated upgrade path in main for reminding the user about notifications
* Tracks from-notification main page views differently from main page views
@dektar
Share code & onResume in tutorial
a59995c
@dektar dektar requested a review from brericha March 2, 2025 22:59
@dektar dektar merged commit 8e69a20 into master Mar 3, 2025
1 check passed
@dektar dektar deleted the tutorialNotifications branch March 3, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brericha brericha brericha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add button to enable reminders in tutorial
2 participants
@dektar @brericha