Add support for detecting async generators #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Async generators are also iterable. This commit also adds a test for sync iterator.
vmx
force-pushed
the
add-async-iterable
branch
from
eefe6c4 to
01425d8
Compare
vmx
added a commit
to ipld/js-ipld
that referenced
this pull request
Feb 28, 2019
Add an additional check for async iterators. This check was also submitted upstream to typical: 75lb/typical#2
|
released in v3.0.1, thanks 👍 |
|
Good idea to put the Node.js 10 specific test into a separate file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Async generators are also iterable.
This commit also adds a test for sync iterator.