replaced acf_get_dir() with acf_get_url() to suppress notice from ACF #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pixelspokefitz according to #6 this was deprecated on v5.6.8 so the fix should only be applied for newer versions or at least those that actually include the method. Haven't checked if that's always been around or not though, so your changes may already be correct (pointing it out just in case). |
|
Hi @pixelspokefitz, Thank you for your contribution. @hacknug is right. We need to have a backwards compatibility with the old versions of ACF and it's important to check which function we should used. Can you update your PR to take into account this please? |
7studio
added
awaiting-reply
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, this will resolve issue #6 would you mind publishing this to the WordPress repository?