Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

callback is not working as expected #44

Closed
GiedriusM opened this issue Mar 29, 2018 · 0 comments
Closed

callback is not working as expected #44

GiedriusM opened this issue Mar 29, 2018 · 0 comments
Labels
not-as-expected between a bug and an enhancement

Comments

@GiedriusM
Copy link

  • Callback registration should try to establish a connection before returning success status
  • Callback is not triggered when registration event happens
  • Callback does not add headers
@GiedriusM GiedriusM added the not-as-expected between a bug and an enhancement label Mar 30, 2018
@Lycopersicum Lycopersicum mentioned this issue Apr 26, 2018
Merged
GiedriusM pushed a commit that referenced this issue Apr 27, 2018
@Lycopersicum @GiedriusM
[restserver] callback API enhancements (#59) (#44)
4d2b85c 
* Add connection establishment test to callback validation function
* Implement callback headers
* Correct check for empty rest event lists before sending notification
* Implement callback deletion
@GiedriusM GiedriusM mentioned this issue Aug 30, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
not-as-expected between a bug and an enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GiedriusM @Lycopersicum