Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface regression #1009

Merged
merged 2 commits into from
Feb 5, 2020
Merged

Interface regression #1009

merged 2 commits into from
Feb 5, 2020

Conversation

vektah
Copy link
Collaborator

@vektah vektah commented Feb 5, 2020

Support using interfaces to back standard graphql types (not interfaces). This also fixes a guard that was preventing binding to interface methods, which I assume was put in place to avoid this bad pointer codepath.

Fixes #920 #955

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@vektah vektah merged commit f7667e1 into master Feb 5, 2020
@vektah vektah deleted the interface-regression branch February 5, 2020 10:52
cgxxv pushed a commit to cgxxv/gqlgen that referenced this pull request Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

regression with interface model
1 participant