Fixed Checkstyle

added 1 more test
AAFC-BICoE · Feb 14, 2024 · a68f6de · a68f6de
1 parent e4fca27
commit a68f6de
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/dina-base-api/src/main/java/ca/gc/aafc/dina/filter/QueryStringParser.java b/dina-base-api/src/main/java/ca/gc/aafc/dina/filter/QueryStringParser.java
@@ -11,7 +11,7 @@
 /**
  * Responsible to parse a query string into a {@link QueryComponent}.
  */
-public class QueryStringParser {
+public final class QueryStringParser {
 
   private QueryStringParser() {
     // utility class

diff --git a/dina-base-api/src/test/java/ca/gc/aafc/dina/filter/AntlrGrammarTest.java b/dina-base-api/src/test/java/ca/gc/aafc/dina/filter/AntlrGrammarTest.java
@@ -3,17 +3,32 @@
 import org.junit.jupiter.api.Test;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
 
 public class AntlrGrammarTest {
 
   @Test
   public void onFilterAsString_structureReturned() {
     String content =
       "filter[name][EQ]=2&filter[position][NEQ]=manager,supervisor&sort=position,-name&page[offset]=5&page[limit]=1&include=author.name";
-    String content2 = "sort=position,-name&page[offset]=5&page[limit]=1&include=author.name";
 
     QueryComponent queryComponent = QueryStringParser.parse(content);
 
+    assertNotNull(queryComponent.getFilters());
+
+    assertEquals("position", queryComponent.getSorts().get(0));
+    assertEquals("-name", queryComponent.getSorts().get(1));
+    assertEquals("author.name", queryComponent.getIncludes().get(0));
+
+    assertEquals(5, queryComponent.getPageOffset());
+    assertEquals(1, queryComponent.getPageLimit());
+  }
+
+  @Test
+  public void onNoFilterAsString_structureReturned() {
+    String content = "sort=position,-name&page[offset]=5&page[limit]=1&include=author.name";
+
+    QueryComponent queryComponent = QueryStringParser.parse(content);
 
     assertEquals("position", queryComponent.getSorts().get(0));
     assertEquals("-name", queryComponent.getSorts().get(1));