This repository has been archived by the owner on Dec 12, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 59
[WIP] Refactor: Tool now self-contained, BuildTime merged into it #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add building samples to GitHub Actions CI runs
Reason: 3.1 introduces ExcludeFromCodeCoverage on ThisAssembly, and the attribute is not available in net20 target from Attributes pkg.
@AArnott as seen in https://github.com/AArnott/CodeGeneration.Roslyn/runs/534972275#step:9:12 Nerdbank.GitVersioning v3.1 introduces ExcludeFromCodeCoverage on ThisAssembly, I had to downgrade. I know net20 is not supported, but maybe you could consider doing an exception for it like you did for netstandard1.x in dotnet/Nerdbank.GitVersioning#453 ? |
This was referenced Mar 25, 2020
Closed
Don't require runtimes not provided by SDK version used.
I've updated the wiki for the newest changes: https://github.com/AArnott/CodeGeneration.Roslyn/wiki/Migrations |
@AArnott macos env in AzurePipelines times out since some time. Edit: |
@amis92 I see you already fixed the macOS problem. :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major refactor.
It's triggered by a disaster of what 0.7.5-alpha turned out to be.
Major features:
dotnet-codegen
package is nowCodeGeneration.Roslyn.Tool
, as per project name.This was done to prevent confusion with previous CLI tool, which it now is not at all,
in terms of either DotNetCliToolReference-style tools and global/local .NET CLI tools.
Tool
is now aDevelopmentDependency=true
normal Dependency package (as in,suitable for
PackageReference
usage. Via various properties, it's setup so that it containsa framework-dependent executable (.dll) with all dependencies included. Using
build/CG.R.Tool.props
file, the path to the executable is set in referencing projects.BuildTime
package's props/targets were merged into theTool
package because a separate package is no longer necessary, and as such necessary consumer dependencies are trimmed downto just
CodeGeneration.Roslyn.Tool
package and a generator plugin of choice.TODO:
To use Sdk package as an Sdk element, the Sdk will need to be published to nuget.org, because MSBuildSdkResolver doesn't work well with local feeds.