Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for importing QIF files #102

Merged
merged 39 commits into from
May 7, 2022
Merged

Add support for importing QIF files #102

merged 39 commits into from
May 7, 2022

Conversation

AArnott
Copy link
Owner

@AArnott AArnott commented May 7, 2022

This isn't all done, mostly because the data model we're importing to doesn't represent everything that QIF can. We'll get more of that as we go.

Closes #99

AArnott and others added 30 commits April 6, 2022 21:55
This is appropriate given QIF files can define all their own accounts.
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2022

Codecov Report

Merging #102 (72092f6) into main (8476f83) will increase coverage by 1.48%.
The diff coverage is 57.68%.

@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
+ Coverage   40.38%   41.87%   +1.48%     
==========================================
  Files          97      101       +4     
  Lines        7060     7788     +728     
==========================================
+ Hits         2851     3261     +410     
- Misses       4209     4527     +318     
Impacted Files Coverage Δ
src/MoneyMan.WPF/UserNotification.cs 5.26% <0.00%> (ø)
...Management/ViewModels/InvestingAccountViewModel.cs 80.20% <0.00%> (-7.30%) ⬇️
...oneyManagement.Tests/Adapters/AdapterTestBase`1.cs 0.00% <0.00%> (ø)
....MoneyManagement.Tests/Adapters/OfxAdapterFacts.cs 0.00% <0.00%> (ø)
....MoneyManagement.Tests/Adapters/QifAdapterFacts.cs 0.00% <0.00%> (ø)
...bank.MoneyManagement.Tests/UserNotificationMock.cs 10.34% <ø> (ø)
...t.Tests/ViewModels/BankingAccountViewModelTests.cs 0.00% <0.00%> (ø)
...ent.Tests/ViewModels/MainPageViewModelBaseTests.cs 0.00% <0.00%> (ø)
...nk.MoneyManagement/ViewModels/DocumentViewModel.cs 69.85% <19.29%> (-12.13%) ⬇️
...rc/Nerdbank.MoneyManagement/Adapters/QifAdapter.cs 90.83% <90.83%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8476f83...72092f6. Read the comment docs.

@AArnott AArnott merged commit be1b481 into main May 7, 2022
@AArnott AArnott deleted the qif_99 branch May 7, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for importing QIF files
2 participants