Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of sorting goodness #41

Merged
merged 7 commits into from
Oct 11, 2021
Merged

Lots of sorting goodness #41

merged 7 commits into from
Oct 11, 2021

Conversation

AArnott
Copy link
Owner

@AArnott AArnott commented Oct 11, 2021

Faster, simpler, consolidated sorting -- in the view model!

  • Fix readonly transaction grid

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2021

Codecov Report

Merging #41 (6f91a4a) into main (1b52702) will decrease coverage by 1.80%.
The diff coverage is 27.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
- Coverage   38.18%   36.38%   -1.81%     
==========================================
  Files          51       53       +2     
  Lines        2320     2666     +346     
==========================================
+ Hits          886      970      +84     
- Misses       1434     1696     +262     
Impacted Files Coverage Δ
src/MoneyMan.WPF/MainWindow.xaml 100.00% <ø> (ø)
...st/Nerdbank.MoneyManagement.Tests/TestUtilities.cs 0.00% <0.00%> (ø)
...nt.Tests/ViewModels/AccountsPanelViewModelTests.cs 0.00% <0.00%> (ø)
...ests/ViewModels/SortedObservableCollectionTests.cs 0.00% <0.00%> (ø)
...ank.MoneyManagement/ViewModels/AccountViewModel.cs 91.60% <75.00%> (-0.53%) ⬇️
...yManagement/ViewModels/CategoriesPanelViewModel.cs 88.88% <87.50%> (-0.73%) ⬇️
src/Nerdbank.MoneyManagement/Utilities.cs 88.00% <100.00%> (-12.00%) ⬇️
...Nerdbank.MoneyManagement/ViewModels/AccountSort.cs 82.35% <100.00%> (+32.35%) ⬆️
...neyManagement/ViewModels/AccountsPanelViewModel.cs 96.47% <100.00%> (ø)
...oneyManagement/ViewModels/BankingPanelViewModel.cs 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b52702...6f91a4a. Read the comment docs.

@AArnott AArnott marked this pull request as draft October 11, 2021 03:53
@AArnott AArnott marked this pull request as ready for review October 11, 2021 04:14
@AArnott AArnott merged commit c65a9a6 into main Oct 11, 2021
@AArnott AArnott deleted the moresorting branch October 11, 2021 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants