Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alloc-free params ReadOnlySpan<object?> overloads to .NET 9 #155

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

AArnott
Copy link
Owner

@AArnott AArnott commented Dec 20, 2024

No description provided.

@AArnott AArnott requested a review from Copilot December 20, 2024 16:46
@AArnott AArnott enabled auto-merge December 20, 2024 16:47
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.

Files not reviewed (2)
  • src/Validation/Validation.csproj: Language not supported
  • test/Validation.Tests/Validation.Tests.csproj: Language not supported

@@ -370,6 +370,18 @@ public static void Argument([DoesNotReturnIf(false)] bool condition, string? par
}
}

#if NET9_0_OR_GREATER
/// <inheritdoc cref="Argument(bool, string?, string, object?[])"/>"
Copy link
Preview

Copilot AI Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The XML documentation tag has an extra double quote at the end. It should be removed.

Suggested change
/// <inheritdoc cref="Argument(bool, string?, string, object?[])"/>"
/// <inheritdoc cref="Argument(bool, string?, string, object?[])"/>

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
@AArnott AArnott merged commit bd6858d into main Dec 20, 2024
3 checks passed
@AArnott AArnott deleted the net9Params branch December 20, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant