-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependencies #96
Conversation
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
=======================================
Coverage 91.43% 91.43%
=======================================
Files 9 9
Lines 292 292
=======================================
Hits 267 267
Misses 25 25 Continue to review full report at Codecov.
|
@AArnott can you release a new NuGet package version without this dependency? Thanks. |
How is this blocking you? |
Yes because we use it with Unity and it only supports .NET Standard 2.0 / 2.1 packages. We use it with: |
Ok. 2.6.13-beta is on its way to nuget.org now. |
Thanks, but that UnityNuGet library only works with stable versions... |
Then you'll need to send a PR to our latest stable branch instead of our main development branch. |
@AArnott what's branch is it? https://github.com/AArnott/Validation/branches/all Thanks! |
Oh, gosh. I guess in this repo I don't have a stable branch for v2.5. Let me get back to you on that. |
Ok. I've pushed a v2.5 branch and cherry-picked your change to it. We'll get a stable 2.5 release out to nuget.org today. |
Bumps [Microsoft.Net.Compilers.Toolset](https://github.com/dotnet/roslyn) from 3.9.0-3.final to 3.9.0. - [Release notes](https://github.com/dotnet/roslyn/releases) - [Changelog](https://github.com/dotnet/roslyn/blob/main/docs/Breaking%20API%20Changes.md) - [Commits](https://github.com/dotnet/roslyn/commits/v3.9.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Remove unnecessary System.Runtime.InteropServices dependency.