Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glo 30 filling #72

Merged
merged 7 commits into from
Jul 26, 2022
Merged

Glo 30 filling #72

merged 7 commits into from
Jul 26, 2022

Conversation

cmarshak
Copy link
Collaborator

@cmarshak cmarshak commented Jun 29, 2022

Resolves #67. Simply updates dem-stitcher to 2.3.0 (see this PR), which, by default, resolves the filling for glo_30 dem.

@cmarshak cmarshak marked this pull request as draft June 29, 2022 21:33
@cmarshak
Copy link
Collaborator Author

The build will fail until the linked to pull request is released on PyPI.

@cmarshak
Copy link
Collaborator Author

cmarshak commented Jun 29, 2022

An example over the problematic area is investigated.

Here is a link to the SLCs on ASF DAAC.

The command to generate a GUNW from the above SLCs is:

isce2_topsapp --reference-scenes S1A_IW_SLC__1SDV_20220625T145353_20220625T145420_043821_053B41_AE0E --secondary-scenes S1A_IW_SLC__1SDV_20220613T145352_20220613T145419_043646_0535FB_8B9A > topsapp_img.out 2> topsapp_img.err

Products for inspection:

  • The output GUNW
  • Low resolution DEM and its xml used for geocoding (isce gdal format)
  • Browse image below

S1-GUNW-A-R-174-tops-20220625_20220613-145406-00044E_00039N-PP-95c8-v2_0_6

Lots of fringes, but likely reasonable due to topography.

@cmarshak
Copy link
Collaborator Author

cmarshak commented Jul 7, 2022

Relevant dem-stitcher will be 2.3.0 per ACCESS-Cloud-Based-InSAR/dem-stitcher#45.

@cmarshak cmarshak marked this pull request as ready for review July 8, 2022 00:20
@cmarshak cmarshak requested a review from sssangha July 8, 2022 00:22
@cmarshak cmarshak requested a review from gracebato July 8, 2022 00:24
@cmarshak cmarshak added the patch Bump the patch version number of this project label Jul 8, 2022
@cmarshak cmarshak requested a review from jhkennedy July 8, 2022 00:53
@cmarshak cmarshak enabled auto-merge July 25, 2022 17:49
@cmarshak
Copy link
Collaborator Author

I have updated the environment.yml file to obtain dem-stitcher 2.3.0 from conda-forge. Assuming it passes, we can merge after @sssangha approves the pull request (I have enabled autom-merge).

Copy link
Collaborator

@sssangha sssangha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cmarshak cmarshak merged commit ff604ff into dev Jul 26, 2022
@cmarshak cmarshak deleted the glo_30_filling branch July 26, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Bump the patch version number of this project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Glo-30 Tiles Results in Faulty GUNW products
3 participants