Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require parallelio 2.5.2 #31

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Require parallelio 2.5.2 #31

merged 1 commit into from
Jan 23, 2024

Conversation

harshula
Copy link
Contributor

See #30

@harshula harshula requested a review from CodeGat January 23, 2024 05:04
@harshula harshula self-assigned this Jan 23, 2024
@harshula harshula force-pushed the 30-require-parallelio-2.5.2 branch from 228f845 to 2ae4924 Compare January 23, 2024 05:05
Copy link
Member

@CodeGat CodeGat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Although not relevant for this particular deployment, note the config/version.json file. It contains the versions of spack-packages and spack-config that will be used to deploy access-om2. Right now they are the latest, but in future this will change.

@CodeGat
Copy link
Member

CodeGat commented Jan 23, 2024

Something also worth noting is that I had to explicitly comment about the config/versions.json thing. This should be a CI check or warning, if a PR hasn't touched that file. Alternatively, a comment could be made, like "This spack.yaml will be used to deploy access-om2 with spack-config vX and spack-packages vY"

Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2

@harshula harshula merged commit feac9d3 into main Jan 23, 2024
4 checks passed
@harshula harshula deleted the 30-require-parallelio-2.5.2 branch January 23, 2024 06:24
@harshula
Copy link
Contributor Author

harshula commented Feb 5, 2024

The following has to be done to deploy these changes: #33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants