-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cmake build copied from COSIMA/access-om3 #6
base: main
Are you sure you want to change the base?
Conversation
0caed91
to
6a78480
Compare
@micaeljtoliveira - if you have time to review that would be great. This builds a library called cicelib from using the nuopc/cmeps driver code and the access3-share libraries. This is a companion PR to ACCESS-NRI/access3-share#2 |
@apcraig - I would like to merge this upstream into the CICE-consortium repository at some point. I don't think there is general interest in a cmake build, so do you have a suggested folder/location for this to be clear its ACCESS specific? (rather than a general CICE thing) |
Hi @anton-seaice. This looks interesting. I don't think we want to move to cmake at the moment, but maybe someone else in the community will find it useful. I don't think it belongs in the cicecore/drivers area. What if we created a new directory, configuration/scripts/cmake (or cmake-access)? We could have a README there that explains it's not used by the standalone model. We could add a little bit of documentation to the user guide to explain how it might be used if someone wanted to use it? Are these cmake scripts fairly general or is the implementation focused on the ACCESS model? What are your thoughts about where we should place them? |
Thanks @apcraig I agree that There are two supported variations here, one is the standalone build. This is fairly general and should work for most people wanting to use cice-standalone. (I had thought I could add this as a CI triggered build, although maybe its not particularly useful ... its slightly related to CICE-Consortium#933) The other one is the cice library using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anton-seaice Overall looks good, just a couple of suggestions/questions. Might come back and have a look at the namespaces once this is settled in your other PR.
9d3a8c6
to
06b34dd
Compare
Add CMake build infrastructure.
CMakelists.txt copied from https://github.com/COSIMA/access-om3/blob/main/CICE/CMakeLists.txt with some common code copied from the top level https://github.com/COSIMA/access-om3/blob/main/CMakeLists.txt.
Closes #5