Dev access candidate 20241217 #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on May 17 2024 with comment 'allow generic tracers in NUOPC cap', see COSIMA/access-om3@857fcda
…on May 21 2024 with comment 'Default coupled gtracer fields to zero if not provided by coupler', see COSIMA/access-om3@69f7199
…on Jul 30 2024 with comment 'Accumulate fluxes%salt_flux_added and pass to generic_tracer_update_from_coupler', see COSIMA/access-om3@63ed4a4
…242be7f32492cb67646b15e8f6fbb9cf01d8b on Oct 23 2024 with comment 'Add patches for truncation output', see COSIMA/access-om3@1933f94 and COSIMA/access-om3@575242b
|
Thanks @chrisb13 I think we should make sure the upstream tests run, they all fail currently (presumably some sort of compilation problem). I think this should go straight to a release branch, as what we put in dev/access needs to be ready to merge into mom-ocean. The truncation output patch (8fd485b) is being fixed elsewhere. The nuopc generic tracers stuff should have better descriptions (which dougie can provide) before we make a PR upstream. |
|
We resolved this by renaming |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging in patches and mom_cap_gtracer_flux.F90 changes as part of MOM6 build update where we build off ACCESS-NRI fork rather than using patches.