Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'Rolling Tag' logic for Prereleases #86

Merged
merged 1 commit into from
May 24, 2024

Conversation

CodeGat
Copy link
Member

@CodeGat CodeGat commented May 24, 2024

We are removing the rolling tag logic because it is causing spack installs to fail. This is because when updating the repository in spack, it fails to git fetch --tags because it would clobber the existing tags.
Removes functionality introduced in the CI (back when it was a part of the model) in ACCESS-NRI/ACCESS-OM2#47

In this PR:

  • ci.yml: Removed shifting tag logic for prereleases, now only do it initially.

References #85

Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming we still tag again on merge.

@CodeGat
Copy link
Member Author

CodeGat commented May 24, 2024

Indeed we do. That is handled in cd.yml, specifically here:

push-tag:
name: Tag Deployment
runs-on: ubuntu-latest
permissions:
contents: write
outputs:
name: ${{ steps.tag.outputs.name }}
steps:
- uses: actions/checkout@v4
- name: Generate Tag
id: tag
# Get the tag name from the `spack.yaml` that was merged into main, which
# is of the form `<model>@git.<version>`.
run: echo "name=$(yq '${{ env.SPACK_YAML_MODEL_YQ }} | split("@git.") | .[1]' spack.yaml)" >> $GITHUB_OUTPUT
- name: Push Tag
# NOTE: Regarding the config user.name/user.email, see https://github.com/actions/checkout/pull/1184
run: |
git config user.name ${{ vars.GH_ACTIONS_BOT_GIT_USER_NAME }}
git config user.email ${{ vars.GH_ACTIONS_BOT_GIT_USER_EMAIL }}
git tag ${{ steps.tag.outputs.name }} --force
git push --tags --force
:)

@CodeGat CodeGat merged commit 50ccf77 into main May 24, 2024
@CodeGat CodeGat deleted the 85-spack-fetch-tags-clobbering-fix branch May 24, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants