-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Execution Block ID uid://A001/X15a0/Xae Sgr_A_st_c_03_7M #14
Comments
I think this looks just about OK...
On 17 Dec 2021, at 13:34, Ashley Barnes ***@***.******@***.***>> wrote:
HCO+
Pretty close to edge of window... Just okay?
This was not included in the regions we wanted to move.
[Screenshot 2021-12-17 at 14 31 16]<https://hes32-ctp.trendmicro.com/wis/clicktime/v1/query?url=https%3a%2f%2fuser%2dimages.githubusercontent.com%2f30494539%2f146552206%2d9a4b98ae%2d289b%2d4a60%2d87b0%2de2ffe266e130.png&umid=8ac5a10d-503e-449b-8218-8cc935135422&auth=768f192bba830b801fed4f40fb360f4d1374fa7c-2dd8c4cadc1b8bab51d94f0fdec64a4f7cbabf0b>
—
Reply to this email directly, view it on GitHub<https://hes32-ctp.trendmicro.com/wis/clicktime/v1/query?url=https%3a%2f%2fgithub.com%2fACES%2dCMZ%2freduction%5fACES%2fissues%2f14%23issuecomment%2d996726617&umid=8ac5a10d-503e-449b-8218-8cc935135422&auth=768f192bba830b801fed4f40fb360f4d1374fa7c-aa90f00c986cc160549ba26744c1fbc5b205ea6c>, or unsubscribe<https://hes32-ctp.trendmicro.com/wis/clicktime/v1/query?url=https%3a%2f%2fgithub.com%2fnotifications%2funsubscribe%2dauth%2fAC6SDE6OITMVNB7JULKJ5BDURM36DANCNFSM5JPUT6UA&umid=8ac5a10d-503e-449b-8218-8cc935135422&auth=768f192bba830b801fed4f40fb360f4d1374fa7c-ab63bc114c38a641fdbb3fc6bd9125e208e921ca>.
Triage notifications on the go with GitHub Mobile for iOS<https://hes32-ctp.trendmicro.com/wis/clicktime/v1/query?url=https%3a%2f%2fapps.apple.com%2fapp%2fapple%2dstore%2fid1477376905%3fct%3dnotification%2demail%26mt%3d8%26pt%3d524675&umid=8ac5a10d-503e-449b-8218-8cc935135422&auth=768f192bba830b801fed4f40fb360f4d1374fa7c-eea9b27e4b77a08886a43a9b1cc242e6c1efd71c> or Android<https://hes32-ctp.trendmicro.com/wis/clicktime/v1/query?url=https%3a%2f%2fplay.google.com%2fstore%2fapps%2fdetails%3fid%3dcom.github.android%26referrer%3dutm%5fcampaign%253Dnotification%2demail%2526utm%5fmedium%253Demail%2526utm%5fsource%253Dgithub&umid=8ac5a10d-503e-449b-8218-8cc935135422&auth=768f192bba830b801fed4f40fb360f4d1374fa7c-2bdc5f1eb8d7d62265cbc08db25e11258c8e9684>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
…________________________________
Important Notice: Liverpool John Moores University was established as a Higher Education Corporation under section 121 of the Education Reform Act 1988. Further information about Liverpool John Moores University can be found at https://www.ljmu.ac.uk/about-us The information in this email and any attachments is for the sole use of the intended recipient(s). If you are not an intended recipient, or a person responsible for delivering it to an intended recipient, you should delete it from your system immediately without disclosing its contents elsewhere and advise the sender by returning the email or by telephoning a number contained in the body of the email. No responsibility is accepted for loss or damage arising from viruses or changes made to this message after it was sent and the recipient must ensure that the email (and attachments) are virus free. The views contained in this email are those of the author and not necessarily those of Liverpool John Moores University. We will use the personal data information provided by you to respond to your email. For information about how we process personal data and monitor communications please see our Privacy Notice. https://www.ljmu.ac.uk/legal/privacy-and-cookies
|
QA Summary
Continuum
Cubes
SPW 20:SPW 22:
|
@d-l-walker the cleanmask shown is the "peak" of the mask - is it possible that means that there are holes in the mask in 3D, but that every spatial pixel has at least one mask-included spectral pixel? I have not inspected the masks carefully for any of these. |
@keflavich oops yeah, you're totally right, not sure how I missed that. Just inspected the 3D mask and it looks good. Thanks for catching that. I'll edit the above to clarify this. |
@d-l-walker It sounds like this whole observation set could be regarded as complete. Could you check off each of the checkboxes you examined? i.e., check the If there are any additional tasks needed - any reimaging - add them as new bulletpoints by editing the main post. Part of the reason I'm asking you to do this is to make sure the permissions are set up so you can. |
@keflavich done. I've made a note that the continuum could be re-imaged to improve the residuals, but this is minor. Is this something that we're worrying about at this stage, or only major issues? If so, I can make a start on improving the cleaning. |
That's a good discussion point to add to the agenda for Wednesday's meeting. I'm not really sure how strict we should be for 7m continuum. On one hand, cleaning deeper isn't going to change the data all that much. On the other, deep cleaning removes (or reduces) the need for JvM correction. If we're planning to use the 7m data for science, we may need the deeper clean - but we should then talk about what approach we'll take for that. |
Okay, good points. I do think it's probably unnecessary to re-clean in this case. I'll leave this as-is for now, and if it's decided that we're not going to re-image cases like this, I'll then move this to completed EBs. |
Update: Following our discussion during yesterday's telecon, I have downloaded the calibrated MSs and will look into re-imaging the continuum to improve the residuals. Given that this is minor and more exploratory, I am leaving this EB marked as completed for the time being. Will update as necessary. |
General consensus from the telecon is that people are happy with re-cleaning in cases such as this. I will work with Adam to push the re-cleaned image and associated products to globus. As requested, here is the full tclean input that I used, which was pulled directly from the CASA log file in the downloaded calibrated directory and changed as described above:
|
Continuum has been (re-)re-imaged with CASA 6.2.1.7 for consistency with pipeline. Products have been transferred to the |
Are there any differences? |
Not as far as I can tell. Minor (< 1%) difference in total/peak flux. Qualitatively looks identical. |
Is that divergent channel from a more recent clean? A re-run of the pipeline? I'm looking at the original cube that I reviewed, and I don't see any divergence in that channel: Regarding the cut off in SPW 20, I think the consensus was that it's probably OK overall, as the bulk of the emission is captured (see averaged spectrum below), but ... the second half of the cube is basically empty, so a shift would be beneficial here. Afaik it wasn't requested, but I don't know for sure? |
yes, it's from the re-run. Why did the re-run fail?! I don't know. |
My failed rerun's log is: https://data.rc.ufl.edu/secure/adamginsburg/ACES/weblogs-reimaging/pipeline-20220227T053557/html/ |
A few things noted in telecon:
|
So this is probably done as long as we only use the original run. But if we use the reimaged (pipeline re-run) products, they're a problem. |
@d-l-walker ![]() |
Hi @pyhsiehATalma please see @keflavich's comment above. For some reason the imaging re-run diverged, while the original PL one did not, as you just showed. We agreed that this issue can be considered to be done as long as we do not use the re-processed cube. @keflavich is this still OK? Should we replace the diverging cube with the original to avoid confusion? |
Maybe we should retry cleaning w/higher cyclefactor.... but I could also just replace them. It just makes for weird bookkeeping |
Product Links:
Reprocessed Product Links:
The text was updated successfully, but these errors were encountered: