Update pipfile and .aicoe-ci for Thoth image build. Include simple donkeycar #26
Conversation
sesheta
added
the
size/XXL
|
Precommit is failing due to the formatting of the default donkey car code. Since the donkeycar project will be integral to this project, is it recommended that we reformat all donkeycar code to meet our pre-commit requirements, or ignore some checks for these files? |
|
@harshad16 @goern shall we approve this PR? Or would you prefer we remove the donkycar skeleton code causing the pre-commit issues for now? |
Pipfile
Outdated
| name = "pypi" | ||
|
|
||
| [packages] | ||
| donkeycar = {editable = true, ref = "81c2ea397695790c370669ce57988c403f7cf7ea", git = "https://github.com/autorope/donkeycar"} |
There was a problem hiding this comment.
I dont know if 'editable' is really meaningful if run from a container image. @pacospace haven't we seen problems arise from this?
There was a problem hiding this comment.
yes in aicoe-aiops/project-template#50 but here there is the reference commit.
to follow good practices for devsecops donkeycar needs to be released on some Python index.
There was a problem hiding this comment.
@pacospace @MichaelClifford shall we create a fork of it and release it as donkeycar-redhat to pypi?! @fridex wdyt?
There was a problem hiding this comment.
We need this package for the demo. If it must be released on an index, then yes, let's create a fork and add it to pypi 👍
There was a problem hiding this comment.
see https://github.com/AICoE/donkeycar and AICoE/common@813e4e8
next: someone needs to setup aicoe-ci to deliver the wheel to pypi as donkeycar-redhat
There was a problem hiding this comment.
I'll look at setting up aicoe-ci pipelines for the donkeycar repo. For now, AICoE/common#42 to get things started
There was a problem hiding this comment.
Thanks @codificat!
Any ETA on this?
There was a problem hiding this comment.
@pacospace @goern I was able to build this successfully using meteor, so the current pipfile seems to work ok. So, my question is, do we need to hold up this PR until donkey-redhat is installable via pipy, or can that come in a later PR?
There was a problem hiding this comment.
An initial version of the package is up in PyPI now if you want to try and use it. The package name is: aicoe-donkeycar
There's also a PR to add aicoe-ci configuration for future updates: AICoE/donkeycar#1
There was a problem hiding this comment.
This issue has been addressed with an updated commit. Thanks for helping me out @codificat
I'm pretty sure you can exclude file or dir or both from pre-commit checks ;) |
Ok, then I'll disable pre-commit checks for the donkeycar directory. 😃 |
MichaelClifford
force-pushed
the
reqs
branch
2 times, most recently
from
f6df7f0 to
f910d7c
Compare
MichaelClifford
force-pushed
the
reqs
branch
from
f910d7c to
06d4bbd
Compare
|
@goern @harshad16 @codificat @harshad16 All comments up to now should have been addressed. Could I get another review from you all? thanks! |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: goern The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sesheta
added
the
approved
Related Issues and Dependencies
Related to #25
This introduces a breaking change
This Pull Request implements
This PR includes the following
default_cardirectory representing the minimal skeleton for a donkeycar.Description