Parsing Julia types from c++ types in yaml description #310

soumilbaldota · 2022-06-28T14:16:32Z

BEGINRELEASENOTES

Adding a new member to Member Variable -> julia_type
Adding a function to parse the cpp type to a julia type
Adding tests to test_MemberParser.py

ENDRELEASENOTES

…ASoft#299) * Handle cases where LD_LIBRARY_PATH is not set * Add protected constructors to CollectionBase

* Split options into several lines for cleaner diffs * Remove no longer available options for disable * Remove no longer available options * Fix pylint warnings (mostly f-string usage)

…collection has been moved (AIDASoft#286)

Flagged by coverity

AIDASoft#305)

* Make SIO collection id writing independent of EventStore * Remove the CollectionID table member Store the necessary information in members that are written to decouple this block more from the details of podio * Move the build version into a separate block

… cmake macro (AIDASoft#282) Co-authored-by: Valentin Volkl <[email protected]>

* hotfix for AIDASoft#290 make sure that there are no unknown symbols in podioDict

tmadlener

Hi @soumilbaldota,

thanks for adding this. This looks pretty good already. I have a few comments inline that would potentially make the parse_julia_type function a bit easier to read as it should hopefully remove a few ifs.

python/generator_utils.py

tmadlener · 2022-06-30T16:11:09Z

The function looks good to me (apart from the nitpicky comment about the f-string).

I see that you have essentially duplicated the file structure of the c++ templates for the julia templates. I am not sure if we need all of those in the end, so I would suggest to add the julia template files as we need them.

pylint seems to be complaining about some formatting: https://github.com/AIDASoft/podio/runs/7131646471?check_suite_focus=true#step:4:280

tmadlener · 2022-06-30T16:16:00Z

Could you also add some checks to the MemberParser tests, to make sure that the parsed julia types are as expected?

These tests are here

podio/python/test_MemberParser.py

Line 15 in 9d078f8

def test_parse_valid(self): # pylint: disable=too-many-statements

The parsed in these tests is a MemberVariable so testing the julia_type should be almost trivial.

tmadlener

Hi @soumilbaldota

this looks good to me. Is there anything still missing from your side, that you would like to still have in this PR?

Otherwise I would suggest to have the next step in a new PR.

soumilbaldota · 2022-07-02T16:18:51Z

Hi @tmadlener ,
There is nothing more on this pull request. It can be merged now.

…473) * Parsing Julia types from c++ types in yaml description (#310) * Julia preprocessing (#311) * adding pre-processing/"include" logic for julia * Add templates for Julia code * Add Julia unittests to test suite (#322) * grouping code into modules * add documentation for Julia code generation (#329) * Added abstract types in default parameters and '-l' language argument * Added --upstream-edm code generation support * Created _sort_components_and_datatypes function to perform topological sort * Added abstract support for builtin Vector Members * Added conditional check for StaticArrays * Suggested Changes * Added ENABLE_JULIA toggle --------- Co-authored-by: soumilbaldota <[email protected]> Co-authored-by: Thomas Madlener <[email protected]>

soumilbaldota and others added 19 commits June 3, 2022 10:27

running pre-commit locally

2facaf4

removing trailing whitespace

38824d8

replace brew with pip

14636c6

Fix a few smaller issues flagged by newer versions of clang-tidy (AID…

5d3b1c2

…ASoft#299) * Handle cases where LD_LIBRARY_PATH is not set * Add protected constructors to CollectionBase

Pylint configuration fixes for newer versions of pylint (AIDASoft#300)

b0b7c12

* Split options into several lines for cleaner diffs * Remove no longer available options for disable * Remove no longer available options * Fix pylint warnings (mostly f-string usage)

changed readme file

99d0ece

Make prepareForWrite thread safe and mark it as const (AIDASoft#295)

20c8bf4

Make sure vector member buffers point to the correct place even if a …

d5a216e

…collection has been moved (AIDASoft#286)

Default initialize array (AIDASoft#303)

b39a915

Flagged by coverity

Fetch the Catch2 3.0.1 release now that it is available (AIDASoft#304)

bbb07af

Release Notes for v00-14-02

1a3b2ff

Updating version to v00-14-02

e327b6b

Add std::string deprecation warning and make sure warnings are printed (

fe94c1f

AIDASoft#305)

Add option to toggle the formatting via clang-format in the generator…

d540fbe

… cmake macro (AIDASoft#282) Co-authored-by: Valentin Volkl <[email protected]>

hotfix for AIDASoft#290 (AIDASoft#307)

f23dfa8

* hotfix for AIDASoft#290 make sure that there are no unknown symbols in podioDict

adding cpp type parsing functionality to generator_utils

281b763

Merge branch 'AIDASoft:master' into parsing_types

379aa21

fixing problem whitespaces and removing jl loading from class generator

c720f31

tmadlener reviewed Jun 28, 2022

View reviewed changes

python/generator_utils.py Outdated Show resolved Hide resolved

python/generator_utils.py Outdated Show resolved Hide resolved

python/generator_utils.py Outdated Show resolved Hide resolved

soumilbaldota added 2 commits June 30, 2022 18:05

update parse_julia_type to get_julia_type

d3e5fd3

small_Change

8bea575

soumilbaldota mentioned this pull request Jun 30, 2022

Parsing cpp types soumilbaldota/PODIO_Julia_Interface_Prototype#7

Closed

fixing precommit-pylint

904b9e3

tmadlener reviewed Jun 30, 2022

View reviewed changes

python/generator_utils.py Outdated Show resolved Hide resolved

soumilbaldota added 2 commits June 30, 2022 23:33

adding tests with minor changes to generator_utils

77d3ed3

fixing GlobalType test and updating generator_utils

7296122

tmadlener approved these changes Jul 1, 2022

View reviewed changes

soumilbaldota closed this Jul 2, 2022

soumilbaldota reopened this Jul 2, 2022

tmadlener changed the title ~~Parsing types~~ Parsing Julia types from c++ types in yaml description Jul 3, 2022

tmadlener merged commit e129173 into AIDASoft:julia Jul 3, 2022

tmadlener pushed a commit that referenced this pull request Aug 11, 2022

Parsing Julia types from c++ types in yaml description (#310)

44e3615

tmadlener pushed a commit that referenced this pull request Aug 16, 2022

Parsing Julia types from c++ types in yaml description (#310)

cd3cd96

Ananya2003Gupta pushed a commit to Ananya2003Gupta/podio that referenced this pull request Sep 1, 2023

Parsing Julia types from c++ types in yaml description (AIDASoft#310)

e67e337

Ananya2003Gupta pushed a commit to Ananya2003Gupta/podio that referenced this pull request Sep 27, 2023

Parsing Julia types from c++ types in yaml description (AIDASoft#310)

1dce825

Ananya2003Gupta pushed a commit to Ananya2003Gupta/podio that referenced this pull request Oct 3, 2023

Parsing Julia types from c++ types in yaml description (AIDASoft#310)

a27742e

Ananya2003Gupta pushed a commit to Ananya2003Gupta/podio that referenced this pull request Nov 14, 2023

Parsing Julia types from c++ types in yaml description (AIDASoft#310)

eb828cc

Ananya2003Gupta pushed a commit to Ananya2003Gupta/podio that referenced this pull request Nov 27, 2023

Parsing Julia types from c++ types in yaml description (AIDASoft#310)

267f4ed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Parsing Julia types from c++ types in yaml description #310

Parsing Julia types from c++ types in yaml description #310

soumilbaldota commented Jun 28, 2022 •

edited

Loading

tmadlener left a comment

tmadlener commented Jun 30, 2022

tmadlener commented Jun 30, 2022

tmadlener left a comment

soumilbaldota commented Jul 2, 2022

Parsing Julia types from c++ types in yaml description #310

Parsing Julia types from c++ types in yaml description #310

Conversation

soumilbaldota commented Jun 28, 2022 • edited Loading

tmadlener left a comment

Choose a reason for hiding this comment

tmadlener commented Jun 30, 2022

tmadlener commented Jun 30, 2022

tmadlener left a comment

Choose a reason for hiding this comment

soumilbaldota commented Jul 2, 2022

soumilbaldota commented Jun 28, 2022 •

edited

Loading