Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make LinkCollectionIterator fulfil std::input_iterator concept #725

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

m-fila
Copy link
Contributor

@m-fila m-fila commented Jan 17, 2025

BEGINRELEASENOTES

  • Updated LinkCollectionIterator to fulifl the same iterator concept and iterator category as other collection iterators. LinkCollection fulfills the same range concepts as other collections. Algorithms like std::ranges::find or std::count are supported.

ENDRELEASENOTES

This is an update for LinkCollectionIterator to behave like component collection iterator -> be LegacyInputIterator and fulfil std::input_iterator which make it compatible with a broad range of standard algorithms ( #626).

For LinkCollection I don't add a documentation page with all the requirements. The test are also simpler and the tests for not supported requirements are skipped

@tmadlener
Copy link
Collaborator

Thanks. Is there an easy way to ensure that we don't forget about these e.g. in #720 ?

@m-fila
Copy link
Contributor Author

m-fila commented Jan 17, 2025

Thanks. Is there an easy way to ensure that we don't forget about these e.g. in #720 ?

I'm afraid I don't have any ideas

@tmadlener
Copy link
Collaborator

Stop adding more "special collections" it is then ;).

@tmadlener tmadlener merged commit ad3fc80 into AIDASoft:master Jan 17, 2025
18 checks passed
@m-fila m-fila deleted the link_iterator branch January 17, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants