Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove iterator-testing code redundant in C++20 #726

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

m-fila
Copy link
Contributor

@m-fila m-fila commented Jan 17, 2025

BEGINRELEASENOTES

  • Removed redundant check for C++20
  • Removed iterator test that is no longer required in C++

ENDRELEASENOTES

Some leftovers from #698
The testsstd::iterator_traits<It>::value_type were originally surrounded by #if (__cplusplus < 202002L) and could be removed

@m-fila m-fila force-pushed the redundant_cplusplus_check branch from 1f00a4c to 2b8b0bd Compare January 17, 2025 13:34
@m-fila
Copy link
Contributor Author

m-fila commented Jan 17, 2025

I forgot to remove the redundant check from documentation. Should be good now

@m-fila m-fila changed the title Remove iterator-testing code redundant in C++ Remove iterator-testing code redundant in C++20 Jan 17, 2025
@tmadlener tmadlener merged commit 7c8d857 into AIDASoft:master Jan 17, 2025
18 checks passed
@m-fila m-fila deleted the redundant_cplusplus_check branch January 17, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants