Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collections.jinja2: improve exception message for untracked relation #728

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

veprbl
Copy link
Contributor

@veprbl veprbl commented Jan 21, 2025

BEGINRELEASENOTES

  • Improved exception message for the case when relation to untracked object is to be persisted.

ENDRELEASENOTES

Copy link
Collaborator

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. I am wondering whether we should also put some more information there, e.g. the name of the relation?

Also, a similar check for single relations doesn't exist. I am no longer sure why we treat them differently, but arguably there should not be a difference, I think.

@veprbl
Copy link
Contributor Author

veprbl commented Jan 21, 2025

That's a good idea. A single relation can be checked too, but that would be a breaking change for the users.

Copy link
Collaborator

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that is true. Let's leave it at the non-breaking improvement for now. I will make a note of figuring out why one-to-one and one-to-many relations are treated differently.

@tmadlener tmadlener merged commit 4e41eb9 into AIDASoft:master Jan 21, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants