Implement forced 2D texture extraction. #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoostJM
force-pushed
the
add-forced-2d-calculation
branch
from
08a1a3a to
10a0eb5
Compare
fedorov
reviewed
Mar 21, 2017
radiomics/imageoperations.py
Outdated
| :return: numpy array with shape (N, 3), where N is the number of unique angles | ||
| """ | ||
|
|
||
| distances = kwargs.get('distances', [1]) | ||
| force2Dextraction = kwargs.get('force2Dextraction', False) | ||
| force2Ddimension = kwargs.get('force2Ddimension', 0) |
There was a problem hiding this comment.
Minor comment - the names of these two are a bit confusing, since to me they both imply boolean type. Maybe call them force2D and force2Ddimension?
There was a problem hiding this comment.
@fedorov good suggestion, thanks! Will change.
Add additional parameters to optionally force texture calculation to 2D. This is enabled by setting parameter `force2Dextraction` to True. Then, all angles moving across 'slices' are removed. The dimension which specifies the slice is defined in `force2Ddimension`. For example, if enabled and dimension is 0, texture is extracted only in the xy-plane (with dimension 0 specifying the 'z' dimension as slice-dimension). Forced 2D extraction is switched off by default. Additionally, enable specifying custom distances between center voxel and neighbors. These distances are specified in the `distances` parameter as a list of integers. By default `disances = [1]`.
As per @fedorov's suggestion, rename this parameter to prevent confusion. Additionally, add the default settings controlling forced 2D extraction to default parameters defined in `featureextractor`. Also update the param schema to allow these setting in the parameter file.
JoostJM
force-pushed
the
add-forced-2d-calculation
branch
from
3427755 to
91d3065
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add additional parameters to optionally force texture calculation to 2D. This is enabled by setting parameter
force2Dextractionto True. Then, all angles moving across 'slices' are removed. The dimension which specifies the slice is defined inforce2Ddimension. For example, if enabled and dimension is 0, texture is extracted only in the xy-plane (with dimension 0 specifying the 'z' dimension as slice-dimension). Forced 2D extraction is switched off by default.Additionally, enable specifying custom distances between center voxel and neighbors. These distances are specified in the
distancesparameter as a list of integers. By defaultdisances = [1].