Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra install step #245

Merged
merged 1 commit into from
Apr 24, 2017
Merged

Add extra install step #245

merged 1 commit into from
Apr 24, 2017

Conversation

pieper
Copy link
Contributor

@pieper pieper commented Apr 21, 2017

Set up developer mode so cmatrices shared library is accessible.

Addresses issue #244

Set up developer mode so cmatrices shared library is accessible.

Addresses [issue #244](#244)
@@ -25,6 +25,9 @@ Installation on your system
* ``cd pyradiomics``
* ``sudo python -m pip install -r requirements.txt``
* ``sudo python setup.py install``

To use your build for interactive use and development:
* ``sudo python setup.py develop``
Copy link
Collaborator

@jcfr jcfr Apr 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and it is consistent with previous steps.

@JoostJM : I would then suggest to remove sudo, this is not a practice to encourage. Regular development should happen as regular user within a virtual environment.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pieper, I agree with @jcfr. Can you remove the sudo's?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pieper, I'll merge this, and then remove the sudo's in the update documentation PR (#233).

@JoostJM JoostJM merged commit dfc164f into master Apr 24, 2017
@JoostJM JoostJM mentioned this pull request Apr 25, 2017
@JoostJM JoostJM deleted the pieper-patch-1-install-step branch February 15, 2018 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants