Update the validation rule for image types #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, available filters were hard coded in the `paramSchema.yaml`, requiring the developer to add any new filters explicitly. Change this to use a schema validation rule which checks against the result of `getImageTypes`, which dynamically enumerates the available filters. Additionally, by applying a regex matching rule that matches any key, the validation rule to test the custom settings is retained.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, available filters were hard coded in the
paramSchema.yaml, requiring the developer to add any new filters explicitly. Change this to use a schema validation rule which checks against the result ofgetImageTypes, which dynamically enumerates the available filters.Additionally, by applying a regex matching rule that matches any key, the validation rule to test the custom settings is retained.