Add Kubernetes collector #836
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #836 +/- ##
==========================================
+ Coverage 64.90% 65.38% +0.48%
==========================================
Files 49 56 +7
Lines 6211 7063 +852
Branches 64 66 +2
==========================================
+ Hits 4031 4618 +587
- Misses 2180 2445 +265
|
collectors/kubernetes/Cargo.toml
Outdated
There was a problem hiding this comment.
Local dependencies can be transitioned to workspace dependencies
| if ! [ -x "$(command -v sqlx)" ]; then | ||
| echo >&2 "Error: sqlx is not installed." | ||
| echo >&2 "Use:" | ||
| echo >&2 " cargo install --version=0.7.2 sqlx-cli --no-default-features --features postgres,rustls,sqlite" |
There was a problem hiding this comment.
This version number is different from the Cargo.toml sqlx dependency version number (v0.7.4)
collectors/kubernetes/src/config.rs
Outdated
| use serde::Deserialize; | ||
| use tracing_subscriber::filter::LevelFilter; | ||
|
|
||
| pub fn load_configuration(p: impl AsRef<Path>) -> Config { |
There was a problem hiding this comment.
load_configuration can be modified to return Result<Config, config::ConfigError>
|
Will do another commit in an hour or so |
|
Hi, I guess it got lost on mattermost, so I will post it here.
|
raghuvar-vijay
previously approved these changes
Nov 25, 2024
raghuvar-vijay
force-pushed
the
kubernetes_collector
branch
from
4b5c7cd to
5013480
Compare
raghuvar-vijay
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first version of the Kubernetes collector.
Still to do:
I found that it doesn't make much sense to use the queued client for this because we need a separate persistent storage anyway. The client would just be a second one.
Note:
I made a little change to AUDITOR: use the Display formatter for the
Displayimplementation ofValidName. Is this ok? If not I can revert this and apply a workaround in the collector.