Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python3.7 support #1635

Merged
merged 64 commits into from
Jan 12, 2022
Merged

Drop Python3.7 support #1635

merged 64 commits into from
Jan 12, 2022

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jan 11, 2022

... following numpy.

Supported Python versions are 3.8--3.10.

All tests are run (at least) on Python 3.8, except for macos tests which uses the default system python (currently 3.9).

Closes #1633

@dweindl dweindl changed the base branch from master to develop January 11, 2022 20:19
@dweindl dweindl marked this pull request as draft January 11, 2022 20:19
@dweindl dweindl changed the base branch from develop to master January 11, 2022 20:26
@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #1635 (93aa5f6) into develop (a4f6610) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1635   +/-   ##
========================================
  Coverage    78.90%   78.90%           
========================================
  Files           69       69           
  Lines        10713    10713           
========================================
  Hits          8453     8453           
  Misses        2260     2260           
Flag Coverage Δ
cpp 75.46% <ø> (ø)
petab 66.68% <ø> (ø)
python 68.23% <ø> (ø)
sbmlsuite 87.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/tests/conftest.py 16.66% <ø> (ø)

@dweindl dweindl changed the base branch from master to develop January 12, 2022 19:38
@dweindl dweindl marked this pull request as ready for review January 12, 2022 20:16
@dweindl dweindl requested a review from FFroehlich January 12, 2022 20:17
@FFroehlich
Copy link
Member

👍

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dweindl dweindl merged commit dd12502 into develop Jan 12, 2022
@dweindl dweindl deleted the drop_py37 branch January 12, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop python 3.7 support
2 participants