Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.14.0 #1898

Merged
merged 19 commits into from
Nov 23, 2022
Merged

Release 0.14.0 #1898

merged 19 commits into from
Nov 23, 2022

Conversation

FFroehlich
Copy link
Member

@FFroehlich FFroehlich commented Nov 23, 2022

v0.14.0 (2022-11-23)

Features:

Fixes:

Documentation:

Full Changelog:
v0.13.0...v0.14.0

dweindl and others added 17 commits October 13, 2022 10:54
for SBML import. Does not currently work with PySB import. Also fixes some argument type issues.

Co-authored-by: Daniel Weindl <[email protected]>
…1877)

Makes the changes from #1810 optional, as sometimes users prefer more flexible models.
The default remains to treat non-estimated parameters in PEtab as constants in AMICI.

Also adds a basic check for loading existing models during PEtab, to see if they are compatible to what was supposed to be imported. Only checks non-constant parameter IDs so far.
Turns out that applying sympy optimizations as introduced
in #1377 is
potentially very costly. Therefore, they are disabled by
default. They can be enabled by setting
`AmiciCxxCodePrinter.optimizations` as shown in the test
case.
Fixes some GHA warnings.
Older binaries are no longer available.
... and set `-Werror` for compiling models in debug mode.
Adds `operator==` for `amici::ExpData` and fixes issues for other  `operator==` in case of NaNs in arrays.


Closes #1880
Setuptools meanwhile requires listing data directories as subpackages. Fixes #1888.
Fixes #1890.

Also: 
* use homebrew boost version
* fix CMake logic for selecting a specific Python version.
Fixes a bug where amici would fail importing an extension that was never built.
@FFroehlich FFroehlich requested a review from dweindl November 23, 2022 16:07
Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #1898 (f6c5732) into master (11a881e) will increase coverage by 0.23%.
The diff coverage is 92.18%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1898      +/-   ##
==========================================
+ Coverage   75.55%   75.78%   +0.23%     
==========================================
  Files          74       75       +1     
  Lines       12877    12913      +36     
==========================================
+ Hits         9729     9786      +57     
+ Misses       3148     3127      -21     
Flag Coverage Δ
cpp 72.84% <94.11%> (+0.02%) ⬆️
petab 59.82% <80.00%> (+0.71%) ⬆️
python 68.97% <53.33%> (-0.08%) ⬇️
sbmlsuite ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/amici/edata.h 0.00% <ø> (ø)
python/sdist/amici/petab_objective.py 93.40% <ø> (-0.10%) ⬇️
python/sdist/amici/setuptools.py 57.69% <0.00%> (ø)
python/tests/test_petab_import.py 100.00% <ø> (+100.00%) ⬆️
include/amici/misc.h 83.72% <80.00%> (-1.13%) ⬇️
python/sdist/amici/cxxcodeprinter.py 89.69% <88.88%> (-0.20%) ⬇️
python/sdist/amici/petab_import.py 65.85% <91.66%> (+1.17%) ⬆️
include/amici/model_state.h 100.00% <100.00%> (ø)
python/sdist/amici/__init__.py 95.55% <100.00%> (+0.43%) ⬆️
python/sdist/amici/ode_export.py 91.74% <100.00%> (-0.03%) ⬇️
... and 7 more

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@FFroehlich FFroehlich merged commit b5177d9 into master Nov 23, 2022
@FFroehlich FFroehlich deleted the release_0.14.0 branch November 23, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants