Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTD: Add run-in-binder links to notebooks #1939

Merged
merged 2 commits into from
Jan 17, 2023
Merged

RTD: Add run-in-binder links to notebooks #1939

merged 2 commits into from
Jan 17, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jan 17, 2023 •
edited
Loading

@codecov
Copy link

codecov bot commented Jan 17, 2023 •
edited
Loading

Codecov Report

Merging #1939 (fc4bdda) into develop (3cb0a32) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1939      +/-   ##
===========================================
+ Coverage    75.94%   75.96%   +0.02%     
===========================================
  Files           76       76              
  Lines        12977    12977              
===========================================
+ Hits          9855     9858       +3     
+ Misses        3122     3119       -3
Flag Coverage Δ
cpp 73.13% <ø> (+0.03%) ⬆️
petab 59.66% <ø> (ø)
python 68.94% <ø> (ø)
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/amici/sundials_matrix_wrapper.h 89.23% <0.00%> (-3.08%) ⬇️
src/exception.cpp 74.28% <0.00%> (ø)
src/solver_cvodes.cpp 70.06% <0.00%> (ø)
src/amici.cpp 75.80% <0.00%> (+4.03%) ⬆️

dweindl added a commit that referenced this pull request Jan 17, 2023
@dweindl
RTD: simplify amici installation
a15119a 
after #1939, we can simply install it via rtd_requirements.txt
@dweindl dweindl mentioned this pull request Jan 17, 2023
Merged
@dweindl dweindl requested a review from FFroehlich January 17, 2023 13:08
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

FFroehlich
FFroehlich approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl dweindl merged commit b58a005 into develop Jan 17, 2023
@dweindl dweindl deleted the binder_prolog branch January 17, 2023 14:38
dweindl added a commit that referenced this pull request Jan 17, 2023
@dweindl
RTD: simplify amici installation
7620363 
after #1939, we can simply install it via rtd_requirements.txt
dweindl added a commit that referenced this pull request Jan 24, 2023
@dweindl
RTD: simplify amici installation (#1940)
2b79ec7 
after #1939, we can simply install it via rtd_requirements.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FFroehlich FFroehlich FFroehlich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dweindl @FFroehlich