Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Update Windows/MSVC installation instructions #2053

Merged
merged 4 commits into from
Apr 22, 2023

Conversation

Podde1
Copy link

@Podde1 Podde1 commented Apr 21, 2023

Updated the description for installation on Windows following installation of AMICI, on Windows 10 running python 3.9. Partly relating to #2012.

  • Added cmake to required softwares
  • Added a notation that compileBLAS.cmd needs to point to the Visual Studio installation
  • Paths to the OpenBLAS installation were updated to be able to set the environmental variables correctly
  • Updated faulty paths for OpenBLAS enviromental variables
  • Updated faulty paths for AMICI_DLL_DIRS enviromental variable

Additionally, added a check in amici.i if AMICI_DLL_DIRS enviromental variable is present

@Podde1 Podde1 requested a review from a team as a code owner April 21, 2023 15:28
@dweindl dweindl self-assigned this Apr 21, 2023
Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@dweindl dweindl changed the title Win installation Doc: Updates Windows/MSVC installation instructions Apr 22, 2023
@dweindl dweindl changed the title Doc: Updates Windows/MSVC installation instructions Doc: Update Windows/MSVC installation instructions Apr 22, 2023
@codecov
Copy link

codecov bot commented Apr 22, 2023

Codecov Report

Merging #2053 (2a7b023) into develop (f40cde9) will decrease coverage by 21.51%.
The diff coverage is n/a.

❗ Current head 2a7b023 differs from pull request most recent head 8aa6172. Consider uploading reports for the commit 8aa6172 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2053       +/-   ##
============================================
- Coverage    75.26%   53.75%   -21.51%     
============================================
  Files           75       29       -46     
  Lines        13011     4535     -8476     
============================================
- Hits          9793     2438     -7355     
+ Misses        3218     2097     -1121     
Flag Coverage Δ
cpp ?
petab 53.75% <ø> (ø)
python ?
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 60 files with indirect coverage changes

@dweindl dweindl merged commit e9a6574 into AMICI-dev:develop Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants