Fix import error for models with events and 0 states #2112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2112 +/- ##
===========================================
- Coverage 76.55% 76.51% -0.04%
===========================================
Files 81 81
Lines 14850 14853 +3
===========================================
- Hits 11368 11365 -3
- Misses 3482 3488 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
FFroehlich
approved these changes
May 25, 2023
| @@ -1992,6 +1992,9 @@ def _compute_equation(self, name: str) -> None: | |||
| for ie in range(self.num_events()) | |||
| ] | |||
|
|
|||
| elif name == "deltasx" and self.num_states_solver() * self.num_par() == 0: | |||
| self._eqs[name] = [] | |||
|
|
|||
| elif name == "deltasx": | |||
There was a problem hiding this comment.
wouldn't it be better to integrate with the code below, i.e. add a special case for self.num_states_solver() * self.num_par() == 0?
There was a problem hiding this comment.
Generally, yes. But I didn't want to increase the nesting depth further. It's already a mess.
There was a problem hiding this comment.
could reuse same initialization and return in case of self.num_states_solver() * self.num_par() == 0 since simplification doesn't do anything.
FFroehlich
approved these changes
May 25, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2109