Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple JAX & C++ code generation #2615

Merged
merged 11 commits into from
Dec 3, 2024
Merged

Decouple JAX & C++ code generation #2615

merged 11 commits into from
Dec 3, 2024

Conversation

FFroehlich
Copy link
Member

Seperates code generation for JAX & C++. Enables alteration of generated symbolics for JAX.

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 98.38710% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.89%. Comparing base (bd3bd91) to head (45c67b2).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
python/sdist/amici/jax/ode_export.py 98.00% 1 Missing ⚠️
python/sdist/amici/pysb_import.py 90.90% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2615      +/-   ##
===========================================
+ Coverage    77.80%   77.89%   +0.08%     
===========================================
  Files          329      330       +1     
  Lines        21737    21833      +96     
  Branches      1477     1477              
===========================================
+ Hits         16912    17006      +94     
- Misses        4814     4816       +2     
  Partials        11       11              
Flag Coverage Δ
cpp 74.14% <78.22%> (-0.01%) ⬇️
cpp_python 33.65% <28.22%> (-0.51%) ⬇️
petab 36.46% <50.00%> (-0.54%) ⬇️
python 72.48% <78.22%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/__init__.py 94.11% <ø> (ø)
python/sdist/amici/de_export.py 97.03% <100.00%> (+0.41%) ⬆️
python/sdist/amici/jax/jaxcodeprinter.py 85.00% <ø> (ø)
python/sdist/amici/petab/import_helpers.py 85.93% <ø> (ø)
python/sdist/amici/petab/petab_import.py 66.66% <ø> (ø)
python/sdist/amici/petab/pysb_import.py 51.85% <ø> (ø)
python/sdist/amici/petab/sbml_import.py 73.33% <100.00%> (+19.04%) ⬆️
python/sdist/amici/sbml_import.py 79.67% <100.00%> (+0.10%) ⬆️
python/sdist/amici/jax/ode_export.py 98.00% <98.00%> (ø)
python/sdist/amici/pysb_import.py 94.15% <90.90%> (-0.15%) ⬇️

@FFroehlich FFroehlich marked this pull request as ready for review December 3, 2024 00:07
@FFroehlich FFroehlich requested a review from a team as a code owner December 3, 2024 00:07
@FFroehlich FFroehlich mentioned this pull request Dec 3, 2024
10 tasks
Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.-

python/sdist/amici/jax/ode_export.py Outdated Show resolved Hide resolved
python/sdist/amici/jax/ode_export.py Outdated Show resolved Hide resolved
python/sdist/amici/jax/ode_export.py Outdated Show resolved Hide resolved
python/sdist/amici/pysb_import.py Outdated Show resolved Hide resolved
python/sdist/amici/petab/sbml_import.py Outdated Show resolved Hide resolved
python/sdist/amici/petab/sbml_import.py Outdated Show resolved Hide resolved
python/sdist/amici/petab/sbml_import.py Outdated Show resolved Hide resolved
python/sdist/amici/petab/sbml_import.py Outdated Show resolved Hide resolved
@FFroehlich FFroehlich merged commit 0d49041 into develop Dec 3, 2024
34 of 38 checks passed
@FFroehlich FFroehlich deleted the decouple_jax_module branch December 3, 2024 12:01
Copy link

sonarqubecloud bot commented Dec 3, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants