Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to the flame_wave flame front analysis scripts #3030

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

yut23
Copy link
Collaborator

@yut23 yut23 commented Feb 7, 2025

PR summary

front_tracker.py

  • dataset processing can run in parallel
  • added code to make interactive plots of each dataset that show the raw slice data, the averaged profile, and the positions for each metric
  • metric thresholds are calculated using both the local maximum and global maximum at the same time (under <field>[<fac>%] and <field>[<fac>%]_gmax, respectively)
  • the local maximum for each field is stored in the output file, in the max_<field> column
  • if a field value never goes below the threshold for a metric, its position will be stored as NaN
  • --[xyz]lim arguments now work, despite some yt bugs
  • allow ignoring plotfiles after a certain time with --tmax
  • default FRB resolution is set to match the finest level, and is automatically adjusted if custom limits are used

flame_speed.py

Now takes min and max times for the linear regression as optional arguments, and can plot multiple metrics at the same time.

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

yut23 added 3 commits February 7, 2025 15:36
* dataset processing can run in parallel
* added code to make interactive plots of each dataset that show the raw
  slice data, the averaged profile, and the positions for each metric
* metric thresholds are calculated using both the local maximum and
  global maximum at the same time (under `<field>[<fac>%]` and
  `<field>[<fac>%]_gmax`, respectively)
* the local maximum for each field is stored in the output file, in the
  `max_<field>` column
* if a field value never goes below the threshold for a metric, its
  position will be stored as NaN
* --[xyz]lim arguments now work, despite some yt bugs
* allow ignoring plotfiles after a certain time with --tmax
* default FRB resolution is set to match the finest level, and is
  automatically adjusted if custom limits are used
Now takes min and max times for the linear regression as optional
arguments, and can plot multiple metrics at the same time.
@yut23 yut23 changed the base branch from main to development February 7, 2025 21:46
@yut23
Copy link
Collaborator Author

yut23 commented Feb 7, 2025

Screenshot of the interactive plots:
Screenshot from 2025-02-07 15-27-08

@yut23
Copy link
Collaborator Author

yut23 commented Feb 7, 2025

The missing checks might be because I opened this PR against main initially. I just ran codespell locally, and it didn't find anything.

@zingale
Copy link
Member

zingale commented Feb 7, 2025

I'm fine with it. You can merge if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants