Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paper compatibility #645

Merged
merged 10 commits into from
Jun 9, 2024
Merged

Fix paper compatibility #645

merged 10 commits into from
Jun 9, 2024

Conversation

TylerS1066
Copy link
Contributor

@TylerS1066 TylerS1066 commented Jun 4, 2024

Describe in detail what your pull request accomplishes

With the update to 1.20.5 paper made a hard fork with respect to accessing Minecraft internals which broke Movecraft: https://forums.papermc.io/threads/important-dev-psa-future-removal-of-cb-package-relocation.1106/

This PR currently is a temporary patch which will get us through 1.20.6, but will not be viable in 1.21+. A decision needs to be made, do we follow Paper in the hard fork or do we stick with Spigot?

Checklist

  • Tested

@Nikkilectric
Copy link

Nikkilectric commented Jun 4, 2024

Doesn't the relocation only affect plugins that parse the server package version? Wouldn't it be much simpler to not parse the version / find an alternative that works with both spigot & paper?

@TylerS1066
Copy link
Contributor Author

TylerS1066 commented Jun 4, 2024

only affect plugins that parse the server package version

Movecraft relies upon parsing the server package version to determine which NMS handler to use. Paper has no alternative option such as a mapping between Minecraft versions and the Spigot NMS handler version.

The proper method to follow Paper's change here is to enumerate the NMS handlers by Minecraft version, not NMS version. However, doing so is a large rewrite, and would break compatibility with Spigot.

@Nikkilectric
Copy link

Ah, alright! Thank you for explaining. Here's hoping we don't lose paper support

@TylerS1066 TylerS1066 linked an issue Jun 8, 2024 that may be closed by this pull request
@TylerS1066 TylerS1066 self-assigned this Jun 8, 2024
@TylerS1066
Copy link
Contributor Author

As mentioned in #647 after internal discussion, we've made the decision to follow the hard fork of Paper. Movecraft 8.0.0 Beta 3 will be the last release to support Spigot servers.

@TylerS1066 TylerS1066 merged commit a5c3d6d into main Jun 9, 2024
9 checks passed
@TylerS1066 TylerS1066 deleted the paper-compat branch June 9, 2024 01:08
@TylerS1066 TylerS1066 mentioned this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paper 1.20.6 support
2 participants