-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Proper access to craft via UUID #673
[Feature] Proper access to craft via UUID #673
Conversation
Also i need this for dispensers in movecraft combat
Movecraft/src/main/java/net/countercraft/movecraft/listener/CraftAssembleListener.java
Outdated
Show resolved
Hide resolved
Movecraft/src/main/java/net/countercraft/movecraft/listener/CraftAssembleListener.java
Outdated
Show resolved
Hide resolved
Movecraft/src/main/java/net/countercraft/movecraft/listener/CraftAssembleListener.java
Outdated
Show resolved
Hide resolved
Movecraft/src/main/java/net/countercraft/movecraft/listener/CraftAssembleListener.java
Outdated
Show resolved
Hide resolved
Movecraft/src/main/java/net/countercraft/movecraft/craft/BaseCraft.java
Outdated
Show resolved
Hide resolved
We've got ourselves some lovely merge conflicts, it's probably best if you rebase this PR. |
Resolved the conflicts, were just some imports. |
Looks like we do need imports for |
…craft into craft-uuid-improvements
Oh, yes, i overlooked that when resolving it, Fixing it rn... |
Looks like we need to add the following imports to import net.countercraft.movecraft.features.status.StatusManager;
import net.countercraft.movecraft.features.status.StatusSign; |
Was this tested on a server? It seems to not be operating correctly.
|
Simple enough fix, |
Describe in detail what your pull request accomplishes
Gives each craft a UUID. Crafts are now tracked in a weak map via their UUID.
Signs will now get a entry into their persistentdatacontainer that represents the craft UUID.
That way you can find the relevant craft for a sign more reliably (needed for a upcoming PR that will greatly change sign codes and make them easier to expand and more maintainable while also allowing other plugins to override the behavior of a specific sign in a easier way).
Checklist