Changed GapAdvertisingData.addData to take current fields into account when adding data. #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if ((_payloadLen - dataLength + len) <= GAP_ADVERTISING_DATA_MAX_PAYLOAD) { | ||
| // remove old field | ||
| while (field + dataLength < &_payload[GAP_ADVERTISING_DATA_MAX_PAYLOAD]) { | ||
| *field = field[dataLength]; |
There was a problem hiding this comment.
shouldn't this be *field = field[dataLength +1];?
…ata fields. Made appendField private.
|
It was actually an off-by-2-error, dataLength + type field + length field. And I forgot to decrement _payloadLen. I changed result to BLE_ERROR_NOT_IMPLEMENTED if the user tries to update a field that is not supported. |
rgrover
added a commit
that referenced
this pull request
Nov 24, 2015
Changed GapAdvertisingData.addData to take current fields into account when adding data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resubmission of #101