Changed onConnection and onDisconnection to accept object/methods and… #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1150,6 +1150,11 @@ class BLE | |||
| gap().onConnection(connectionCallback); | |||
| } | |||
|
|
|||
| template<typename T> | |||
There was a problem hiding this comment.
Hi, can we not do this for BLE.h (because that's deprecated space)? let's limit it to Gap.h, shall we?
thanks.
|
i'm satisfied with this except for the minor changes I've recommended. And do we need the inclusion of mbed.h? |
… merged them with the addTo-callchain. All calls to onConnection and onDisconnection will now be added to a call chain.
rgrover
added a commit
that referenced
this pull request
Sep 21, 2015
Changed onConnection and onDisconnection to accept object/methods and…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… merged them with the addTo-callchain. All calls to onConnection and onDisconnection will now be added to a call chain.