Adding Eddystone Support #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| static const uint8_t UUID_TX_POWER_MODE_CHAR[] = UUID_URI_BEACON(0x20, 0x87); | ||
| static const uint8_t UUID_BEACON_PERIOD_CHAR[] = UUID_URI_BEACON(0x20, 0x88); | ||
| static const uint8_t UUID_RESET_CHAR[] = UUID_URI_BEACON(0x20, 0x89); | ||
| extern const uint8_t BEACON_EDDYSTONE[2]; |
There was a problem hiding this comment.
can you align this declaration with the ones above?
|
Feel free to make whatever cosmetic changes you want to. |
| // TLM Frame Data | ||
| uint8_t tlmVersion; // version of TLM packet | ||
| bool tlmEnabled; | ||
| float tlmBeaconPeriod; // how often to broadcat TLM frame, in S |
|
OK. I'll make cosmetic changes. Could you please test the result? thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the result of my work with Google to enable the eddystone beacon service and the eddystone config service.