Skip to content

Commit

Permalink
Unit tests: Remove redundant CMake target mbed-headers-base
Browse files Browse the repository at this point in the history
Individual libraries' `target_h` stub headers have now all been moved
from `mbed-headers-base` to `mbed-headers-<library>`.

Note: Even though headers previously in `target_h` are technically
stubs/fakes too, they are used by not only unit tests but also regular
libraries when compiled for unit tests, because no target-specific HAL
implementation exists in this case. In order for regular library
sources to pick up `target_h` headers, those headers must

* have the same names as regular headers
* appear first in include paths

This is why those headers are part of `mbed-headers-<library>` and not
`mbed-stubs-<library>`. Before this refactoring, `mbed-headers-base`
was the first in unit tests' include paths.
  • Loading branch information
LDong-Arm committed Jul 16, 2021
1 parent 7f11b80 commit 079538a
Show file tree
Hide file tree
Showing 25 changed files with 0 additions and 37 deletions.
13 changes: 0 additions & 13 deletions UNITTESTS/stubs/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,10 @@

add_library(mbed-stubs-headers INTERFACE)
add_library(mbed-headers INTERFACE)
add_library(mbed-headers-base INTERFACE)
add_library(mbed-headers-connectivity INTERFACE)

target_link_libraries(mbed-headers
INTERFACE
mbed-headers-base
mbed-headers-platform
mbed-headers-connectivity
mbed-headers-drivers
Expand All @@ -17,17 +15,6 @@ target_link_libraries(mbed-headers
mbed-headers-rtos
)

target_include_directories(mbed-headers-base
INTERFACE
${mbed-os_SOURCE_DIR}/UNITTESTS/target_h
${mbed-os_SOURCE_DIR}/UNITTESTS/target_h/platform
${mbed-os_SOURCE_DIR}/UNITTESTS/target_h/platform/cxxsupport
${mbed-os_SOURCE_DIR}/UNITTESTS/target_h/drivers
${mbed-os_SOURCE_DIR}/UNITTESTS/target_h/rtos/include
${mbed-os_SOURCE_DIR}/UNITTESTS/target_h/rtos
${mbed-os_SOURCE_DIR}/UNITTESTS/target_h/sys
)

target_include_directories(mbed-headers-connectivity
INTERFACE
${mbed-os_SOURCE_DIR}/connectivity
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ target_sources(mbed-stubs-cellular

target_link_libraries(mbed-stubs-cellular
PRIVATE
mbed-headers-base
mbed-headers-connectivity
mbed-stubs-platform
mbed-headers-rtos
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ target_sources(mbed-stubs-lorawan

target_link_libraries(mbed-stubs-lorawan
PRIVATE
mbed-headers-base
mbed-headers-events
mbed-headers-hal
mbed-stubs-headers
Expand Down
1 change: 0 additions & 1 deletion drivers/tests/UNITTESTS/PwmOut/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ target_sources(${TEST_NAME}

target_link_libraries(${TEST_NAME}
PRIVATE
mbed-headers-base
mbed-headers-platform
mbed-headers-hal
mbed-headers-drivers
Expand Down
1 change: 0 additions & 1 deletion drivers/tests/UNITTESTS/Watchdog/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ target_sources(${TEST_NAME}

target_link_libraries(${TEST_NAME}
PRIVATE
mbed-headers-base
mbed-headers-hal
mbed-headers-drivers
mbed-headers-platform
Expand Down
1 change: 0 additions & 1 deletion drivers/tests/UNITTESTS/doubles/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ target_compile_definitions(mbed-stubs-drivers

target_link_libraries(mbed-stubs-drivers
PRIVATE
mbed-headers-base
mbed-headers-hal
mbed-headers-drivers
mbed-headers-platform
Expand Down
1 change: 0 additions & 1 deletion events/tests/UNITTESTS/doubles/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ target_include_directories(mbed-stubs-events

target_link_libraries(mbed-stubs-events
PRIVATE
mbed-headers-base
mbed-headers-drivers
mbed-headers-hal
mbed-headers-events
Expand Down
1 change: 0 additions & 1 deletion events/tests/UNITTESTS/equeue/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ target_sources(${TEST_NAME}

target_link_libraries(${TEST_NAME}
PRIVATE
mbed-headers-base
mbed-headers-platform
mbed-headers-events
mbed-stubs-events
Expand Down
1 change: 0 additions & 1 deletion hal/tests/UNITTESTS/doubles/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ target_sources(mbed-stubs-hal

target_link_libraries(mbed-stubs-hal
PRIVATE
mbed-headers-base
mbed-headers-hal
mbed-headers-platform
mbed-stubs-headers
Expand Down
1 change: 0 additions & 1 deletion platform/tests/UNITTESTS/doubles/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ target_include_directories(mbed-stubs-platform
)
target_link_libraries(mbed-stubs-platform
PUBLIC
mbed-headers-base
mbed-headers-hal
mbed-headers-platform
)
1 change: 0 additions & 1 deletion rtos/tests/UNITTESTS/doubles/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ target_sources(mbed-stubs-rtos

target_link_libraries(mbed-stubs-rtos
PRIVATE
mbed-headers-base
mbed-headers-rtos
mbed-headers-platform
mbed-headers-drivers
Expand Down
1 change: 0 additions & 1 deletion storage/blockdevice/tests/UNITTESTS/SFDP/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ target_sources(${TEST_NAME}

target_link_libraries(${TEST_NAME}
PRIVATE
mbed-headers-base
mbed-headers-blockdevice
mbed-headers-platform
mbed-stubs-platform
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ target_sources(${TEST_NAME}

target_link_libraries(${TEST_NAME}
PRIVATE
mbed-headers-base
mbed-headers-blockdevice
mbed-headers-platform
mbed-stubs-headers
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ target_sources(${TEST_NAME}

target_link_libraries(${TEST_NAME}
PRIVATE
mbed-headers-base
mbed-headers-blockdevice
mbed-headers-platform
mbed-stubs-headers
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ target_sources(${TEST_NAME}

target_link_libraries(${TEST_NAME}
PRIVATE
mbed-headers-base
mbed-headers-blockdevice
mbed-headers-platform
mbed-stubs-headers
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ target_sources(${TEST_NAME}

target_link_libraries(${TEST_NAME}
PRIVATE
mbed-headers-base
mbed-headers-blockdevice
mbed-headers-platform
mbed-stubs-headers
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ target_sources(${TEST_NAME}

target_link_libraries(${TEST_NAME}
PRIVATE
mbed-headers-base
mbed-headers-blockdevice
mbed-headers-platform
mbed-stubs-platform
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ target_sources(${TEST_NAME}

target_link_libraries(${TEST_NAME}
PRIVATE
mbed-headers-base
mbed-headers-blockdevice
mbed-headers-platform
mbed-stubs-headers
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ target_sources(${TEST_NAME}

target_link_libraries(${TEST_NAME}
PRIVATE
mbed-headers-base
mbed-headers-blockdevice
mbed-headers-platform
mbed-stubs-headers
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ target_sources(${TEST_NAME}

target_link_libraries(${TEST_NAME}
PRIVATE
mbed-headers-base
mbed-headers-blockdevice
mbed-headers-platform
mbed-stubs-headers
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ target_sources(${TEST_NAME}

target_link_libraries(${TEST_NAME}
PRIVATE
mbed-headers-base
mbed-headers-blockdevice
mbed-headers-platform
mbed-stubs-headers
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ target_sources(${TEST_NAME}

target_link_libraries(${TEST_NAME}
PRIVATE
mbed-headers-base
mbed-headers-blockdevice
mbed-headers-platform
mbed-stubs-platform
Expand Down
1 change: 0 additions & 1 deletion storage/blockdevice/tests/UNITTESTS/doubles/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ target_sources(mbed-stubs-blockdevice

target_link_libraries(mbed-stubs-blockdevice
PRIVATE
mbed-headers-base
mbed-headers-platform
mbed-headers-blockdevice
)
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ target_sources(${TEST_NAME}

target_link_libraries(${TEST_NAME}
PRIVATE
mbed-headers-base
mbed-headers-blockdevice
mbed-headers-drivers
mbed-headers-filesystem
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ target_sources(${TEST_NAME}

target_link_libraries(${TEST_NAME}
PRIVATE
mbed-headers-base
mbed-headers-blockdevice
mbed-headers-drivers
mbed-headers-hal
Expand Down

0 comments on commit 079538a

Please sign in to comment.