Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serial: remove shadowing member variables #14678

Merged
merged 1 commit into from
May 24, 2021
Merged

Serial: remove shadowing member variables #14678

merged 1 commit into from
May 24, 2021

Conversation

ghseb
Copy link

@ghseb ghseb commented May 19, 2021 •
edited by adbridge
Loading

Summary of changes

As requested, the changes of #14498 should be brought to master.

  • The variables shadow SerialBase::_tx_enabled and SerialBase::_rx_enabled
  • Update interrupts when input/output is enabled to avoid infinite congestion
  • Update comments

Impact of changes

Migration actions required

None

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

Remove shadowing member variables
77b5ffc 
- The variables shadow SerialBase::_tx_enabled and SerialBase::_rx_enabled
- Update interrupts when input/output is enabled to avoid infinite congestion
- Update comments
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label May 19, 2021
@ciarmcom ciarmcom requested a review from a team May 19, 2021 07:30
@ciarmcom
Copy link
Member

@ghseb, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 changed the title Remove shadowing member variables Serial: remove shadowing member variables May 19, 2021
@mergify mergify bot added needs: CI and removed needs: review labels May 19, 2021
@ciarmcom
Copy link
Member

This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please start CI to get the PR merged.

@ciarmcom ciarmcom added the stale Stale Pull Request label May 20, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented May 20, 2021

CI started

@0xc0170 0xc0170 removed the stale Stale Pull Request label May 20, 2021
@ciarmcom ciarmcom added the stale Stale Pull Request label May 20, 2021
@mbed-ci
Copy link

mbed-ci commented May 20, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 removed the stale Stale Pull Request label May 21, 2021
@adbridge adbridge merged commit e0069d8 into ARMmbed:master May 24, 2021
@mergify mergify bot removed the ready for merge label May 24, 2021
@ghseb ghseb deleted the uartserial-shadowing-2 branch June 7, 2021 06:20
@mbedmain mbedmain added release-version: 6.12.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@kjbracey kjbracey kjbracey approved these changes

Assignees
No one assigned
Labels
component: core component: hal release-version: 6.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ghseb @ciarmcom @0xc0170 @mbed-ci @kjbracey @adbridge @mbedmain