Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STM32: correct __cplusplus brackets #14686

Merged
merged 2 commits into from
Jun 2, 2021
Merged

STM32: correct __cplusplus brackets #14686

merged 2 commits into from
Jun 2, 2021

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

Fix #14676

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@jeromecoutant jeromecoutant mentioned this pull request May 20, 2021
Closed
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label May 20, 2021
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team May 20, 2021 09:30
0xc0170
0xc0170 previously approved these changes May 21, 2021
View reviewed changes
@mergify mergify bot added needs: CI and removed needs: review labels May 21, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented May 21, 2021

CI started

@mergify mergify bot added needs: work and removed needs: CI labels May 21, 2021
@mbed-ci
Copy link

mbed-ci commented May 21, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ❌
jenkins-ci/mbed-os-ci_cmake-example-ARM ❌
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ❌
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ❌
jenkins-ci/mbed-os-ci_build-example-ARM ❌
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ❌

@jeromecoutant
Copy link
Collaborator Author

Let's restart CI ?
Thx

@mergify mergify bot dismissed 0xc0170’s stale review May 21, 2021 15:30

Pull request has been modified.

@mergify mergify bot added needs: work and removed needs: CI labels May 24, 2021
@mergify
Copy link

mergify bot commented May 24, 2021

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@jeromecoutant
Copy link
Collaborator Author

This PR cannot be merged due to conflicts. Please rebase to resolve them.

Done

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 1, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 1, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 0711e48 into ARMmbed:master Jun 2, 2021
@mergify mergify bot removed the ready for merge label Jun 2, 2021
@jeromecoutant jeromecoutant deleted the PR_CPP branch June 2, 2021 12:00
@mbedmain mbedmain added release-version: 6.12.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
devices: st release-version: 6.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unmatched bracket in stm32F4 i2c_device.h
5 participants
@jeromecoutant @ciarmcom @0xc0170 @mbed-ci @mbedmain