Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation errors with kvstore - TDB_INTERNAL option to store BLE bonding info #14693

Merged
merged 4 commits into from
Jun 9, 2021

Conversation

16L-YT
Copy link
Contributor

@16L-YT 16L-YT commented May 22, 2021

Summary of changes

This fixes 3 errors:

  1. "kvstore_global_api.h: No such file or directory" compilation error when ble-security-database-kvstore is true.
  2. Missing as_entry definition in the header KVStoreSecurityDb.h.
  3. Type conversion error in one of the tracing messages in KVStoreSecurityDb.cpp (adapted from Fix missing as_entry method in KVStoreSecurityDb #14684 to keep the 2 PRs compatible).

Refere to #14660 .

Impact of changes

Migration actions required

Documentation


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label May 22, 2021
@ciarmcom ciarmcom requested a review from a team May 22, 2021 09:30
@ciarmcom
Copy link
Member

@16L-YT, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@16L-YT 16L-YT changed the title Fix compilation errors when kvstore - TDB_INTERNAL to store BLE bonding info Fix compilation errors with kvstore - TDB_INTERNAL option to store BLE bonding info May 22, 2021
@mergify
Copy link

mergify bot commented May 24, 2021

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@ciarmcom ciarmcom added the stale Stale Pull Request label Jun 3, 2021
@ciarmcom
Copy link
Member

ciarmcom commented Jun 3, 2021

This pull request has automatically been marked as stale because it has had no recent activity. @16L-YT, please carry out any necessary work to get the changes merged. Thank you for your contributions.

@ciarmcom ciarmcom removed the stale Stale Pull Request label Jun 4, 2021
@16L-YT
Copy link
Contributor Author

16L-YT commented Jun 5, 2021

@0xc0170 @noonfom
What should I do next step, why it is stalled ?

@ciarmcom ciarmcom added the stale Stale Pull Request label Jun 6, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 7, 2021

Thanks @16L-YT for the reminder, I'll review shortly and remove stale label.

@0xc0170 0xc0170 added needs: review and removed needs: work stale Stale Pull Request labels Jun 7, 2021
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for @ARMmbed/mbed-os-connectivity team to review.

From what I see, files in generic require these libraries unconditionally.

@mergify mergify bot added needs: CI and removed needs: review labels Jun 7, 2021
@noonfom
Copy link

noonfom commented Jun 8, 2021

I can't officially approve this so please accept this comment as my approval 😉

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 9, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 9, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit a8fd7b3 into ARMmbed:master Jun 9, 2021
@mergify mergify bot removed the ready for merge label Jun 9, 2021
@mbedmain mbedmain added release-version: 6.12.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants