Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: Upgrade GCC to 10.3-2021.07 #15007

Merged
merged 1 commit into from
Sep 7, 2021
Merged

docker: Upgrade GCC to 10.3-2021.07 #15007

merged 1 commit into from
Sep 7, 2021

Conversation

Patater
Copy link
Contributor

@Patater Patater commented Aug 16, 2021

Summary of changes

Upgrade to the current latest version of GNU Arm Embedded,
gcc-arm-none-eabi-10.3-2021.07. This brings along fixes to v8-M targets
and better Cortex-M55 support.

Impact of changes

None

Migration actions required

None

Documentation

None

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@saheerb

@Patater
docker: Upgrade GCC to 10.3-2021.07
432cf28 
Upgrade to the current latest version of GNU Arm Embedded,
gcc-arm-none-eabi-10.3-2021.07. This brings along fixes to v8-M targets
and better Cortex-M55 support.
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Aug 16, 2021
@ciarmcom ciarmcom requested review from saheerb and a team August 16, 2021 16:00
@ciarmcom
Copy link
Member

@Patater, thank you for your changes.
@saheerb @ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 previously approved these changes Aug 17, 2021
View reviewed changes
@mergify mergify bot added needs: CI and removed needs: review labels Aug 17, 2021
@saheerb
Copy link
Contributor

saheerb commented Aug 17, 2021

Let's wait for the CI environment to get updated to GCC-10 before merging this in.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 17, 2021

Let's wait for the CI environment to get updated to GCC-10 before merging this in.

"needs: preceding PR" applied, will wait until you confirm Arm Gcc was updated

saheerb
saheerb previously approved these changes Aug 17, 2021
View reviewed changes
@ciarmcom ciarmcom added the stale Stale Pull Request label Aug 18, 2021
@ciarmcom
Copy link
Member

This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please start CI to get the PR merged.

@Patater Patater mentioned this pull request Aug 19, 2021
Closed
@ciarmcom ciarmcom added stale Stale Pull Request and removed stale Stale Pull Request labels Aug 20, 2021
@ciarmcom ciarmcom added stale Stale Pull Request and removed stale Stale Pull Request labels Aug 27, 2021
@ciarmcom ciarmcom added stale Stale Pull Request and removed stale Stale Pull Request labels Sep 3, 2021
@donatieng donatieng mentioned this pull request Sep 6, 2021
Merged
@0xc0170 0xc0170 removed needs: preceding PR stale Stale Pull Request labels Sep 6, 2021
@saheerb
Copy link
Contributor

saheerb commented Sep 6, 2021

This can be now merged in as GCC_ARM updated in CI.

@mbed-ci
Copy link

mbed-ci commented Sep 6, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

0xc0170
0xc0170 previously approved these changes Sep 6, 2021
View reviewed changes
@Patater
Copy link
Contributor Author

Patater commented Sep 6, 2021

I've added a commit to remove the annoying GCC version mismatch warning. This will fail the tools check, as previously discussed.

@Patater Patater requested a review from saheerb September 6, 2021 13:53
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 6, 2021

CI restarted

@saheerb
Copy link
Contributor

saheerb commented Sep 6, 2021

May be we need to disable frozen-tools-check in GitHub Action workflow.

@mbed-ci
Copy link

mbed-ci commented Sep 6, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@saheerb
Copy link
Contributor

saheerb commented Sep 6, 2021

@Patater I think it is better to separate docker changes and tool changes as building Docker is a very slow CI run (due to aarch64 virtualisation).

@Patater
Copy link
Contributor Author

Patater commented Sep 6, 2021

@Patater I think it is better to separate docker changes and tool changes as building Docker is a very slow CI run (due to aarch64 virtualisation).

OK, I'll back out the tools changes and handle them in a separate PR, given I need to fix python test failures there anyway.

@mergify mergify bot dismissed 0xc0170’s stale review September 6, 2021 14:49

Pull request has been modified.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 6, 2021

CI restarted

@mbed-ci
Copy link

mbed-ci commented Sep 6, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit d1f02f3 into ARMmbed:master Sep 7, 2021
@mergify mergify bot removed the ready for merge label Sep 7, 2021
@mbedmain mbedmain added release-version: 6.15.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Sep 16, 2021
@0xc0170 0xc0170 mentioned this pull request Oct 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@saheerb saheerb Awaiting requested review from saheerb

Assignees
No one assigned
Labels
release-version: 6.15.0 story: september release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Patater @ciarmcom @saheerb @0xc0170 @mbed-ci @mbedmain