Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add USBDEVICE to NUCLEO_F722ZE target #15205

Merged

Conversation

mikrodust-henrikp
Copy link
Contributor

USB was missing from NUCLEO_F722ZE but is present and working on the board.

Summary of changes

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


USB was missing from NUCLEO_F722ZE but is present and working on the
board.
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jan 14, 2022
@ciarmcom ciarmcom requested a review from a team January 14, 2022 11:00
@ciarmcom
Copy link
Member

@mikrodust-henrikp, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 requested a review from a team January 14, 2022 11:01
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 14, 2022

Was this tested with some examples/ run tests?

@mikrodust-henrikp
Copy link
Contributor Author

Yes, I have a project which have been running for some time (but with the nucleo f722 in custom_targets, which we have now removed in favor of this upstream one). Added USBDEVICE and compiled, verified to be working.

@mergify mergify bot added the needs: CI label Jan 17, 2022
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 17, 2022

CI started

@mergify mergify bot removed the needs: review label Jan 17, 2022
@mbed-ci
Copy link

mbed-ci commented Jan 17, 2022

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit d234b35 into ARMmbed:master Jan 17, 2022
@mergify mergify bot removed the ready for merge label Jan 17, 2022
@mbedmain mbedmain added release-version: 6.16.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants