Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STM32WL preparation for new chip rak3172sip #15312

Merged
merged 1 commit into from
Aug 17, 2022
Merged

STM32WL preparation for new chip rak3172sip #15312

merged 1 commit into from
Aug 17, 2022

Conversation

hallard
Copy link
Contributor

@hallard hallard commented Jul 25, 2022

Summary of changes

New chip RAK3172SIP need some changes, thus some values are now used as parameter in mbed_app.json

Impact of changes

Migration actions required

Documentation

  • Added tcxo_ctrlas a parameter since RAK3172SIP need default value do be changed from TCXO_CTRL_1_7V to TCXO_CTRL_3_0V (today it was hardcoded)
            "stm32wl-lora-driver.tcxo_ctrl": "TCXO_CTRL_3_0V",
  • Added option to remove Low Power fix used on boards with RFO_HP path only (LoRa-E5 and RAK3172) now you can disable this fix (this one is effective only if stm32wl-lora-driver.rf_switch_config is set to RBI_CONF_RFO_HP(really specific boards)
            "stm32wl-lora-driver.rf_rfo_hp_lpfix": 0,

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@jeromecoutant

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jul 25, 2022
@ciarmcom ciarmcom requested review from jeromecoutant and a team July 25, 2022 20:30
@ciarmcom
Copy link
Member

@hallard, thank you for your changes.
@jeromecoutant @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 3, 2022 •
edited
Loading

Can you please fix the commit message:

Allow to use TCXO Control Voltage and LowPower fix as a parameter

Allow to use TCXO Control Voltage and LowPower fix as a parameter

leave current default value to avoid breaking changes

Remove duplication

@hallard
Copy link
Contributor Author

hallard commented Aug 3, 2022 •
edited
Loading

Still not git guru, tried to git commit --amend looks like worked but added a merge, not sure what's went wrong, but looks ok

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 3, 2022

It looks like you merged instead of rebase. Can you rebase your branch from master (it will remove the merge commit) ?

@hallard
Copy link
Contributor Author

hallard commented Aug 3, 2022

looks like it's good now, let me know

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 3, 2022

looks like it's good now, let me know

+1, thanks

@hallard
Allow to use LowPower fix as a parameter
42e11ac 
Allow to use TCXO Control Voltage and LowPower fix as a parameter

leave current default value to avoid breaking changes

astyle fix
@mergify mergify bot added needs: CI and removed needs: work labels Aug 17, 2022
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 17, 2022

Ci started

@mbed-ci
Copy link

mbed-ci commented Aug 17, 2022

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit b482f2d into ARMmbed:master Aug 17, 2022
@mergify mergify bot removed the ready for merge label Aug 17, 2022
@hallard hallard changed the title STMWL32 preparation for new chip rak3172sip STM32WL preparation for new chip rak3172sip Aug 17, 2022
@hallard hallard deleted the prep_rak3172sip branch August 17, 2022 11:17
@mbedmain mbedmain removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Feb 28, 2023
@hallard hallard mentioned this pull request Apr 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromecoutant jeromecoutant jeromecoutant approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
component: connectivity release-version: 6.17.0 release-version: 6.18.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hallard @ciarmcom @0xc0170 @mbed-ci @jeromecoutant @saheerb @mbedmain